From: Changheun Lee <nanich.lee@samsung.com>
To: bvanassche@acm.org
Cc: Johannes.Thumshirn@wdc.com, asml.silence@gmail.com,
axboe@kernel.dk, damien.lemoal@wdc.com,
gregkh@linuxfoundation.org, hch@infradead.org,
jisoo2146.oh@samsung.com, junho89.kim@samsung.com,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
ming.lei@redhat.com, mj0123.lee@samsung.com,
nanich.lee@samsung.com, osandov@fb.com, patchwork-bot@kernel.org,
seunghwan.hyun@samsung.com, sookwan7.kim@samsung.com,
tj@kernel.org, tom.leiming@gmail.com, woosung2.lee@samsung.com,
yt0928.kim@samsung.com
Subject: Re: [PATCH v8] bio: limit bio max size
Date: Thu, 22 Apr 2021 08:51:24 +0900 [thread overview]
Message-ID: <20210421235124.31579-1-nanich.lee@samsung.com> (raw)
In-Reply-To: <55adfb07-7f10-7ad6-e05d-7aeb7d9c3b29@acm.org>
> On 4/21/21 2:47 AM, Changheun Lee wrote:
> > bio size can grow up to 4GB when muli-page bvec is enabled.
> > but sometimes it would lead to inefficient behaviors.
> > in case of large chunk direct I/O, - 32MB chunk read in user space -
>
> This patch looks good to me, hence:
>
> Reviewed-by: Bart Van Assche <bvanassche@acm.org>
>
> Do you plan to submit a dm-crypt patch that limits the bio size when
> using dm-crypt to the bio size of the underling device?
>
> Thanks,
>
> Bart.
Yes, I'm preparing a dm-crypt patch. I'll upstream after applying of this.
Thank you for your review, and advice. :)
Thanks,
Changheun Lee.
next prev parent reply other threads:[~2021-04-22 0:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20210421100544epcas1p13c2c86e84102f0955dd591f72e45756a@epcas1p1.samsung.com>
2021-04-21 9:47 ` [PATCH v8] bio: limit bio max size Changheun Lee
2021-04-21 16:29 ` Bart Van Assche
[not found] ` <CGME20210422000922epcas1p4bb2d0220652f3c497f063719f82bc829@epcas1p4.samsung.com>
2021-04-21 23:51 ` Changheun Lee [this message]
2021-04-22 20:33 ` Bart Van Assche
2021-04-23 11:36 ` Damien Le Moal
2021-04-23 14:38 ` Jens Axboe
2021-04-25 2:20 ` [bio] 803f54ef52: BUG:kernel_NULL_pointer_dereference,address kernel test robot
2021-04-26 13:18 ` [PATCH v8] bio: limit bio max size Marek Szyprowski
2021-04-26 20:09 ` Jon Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210421235124.31579-1-nanich.lee@samsung.com \
--to=nanich.lee@samsung.com \
--cc=Johannes.Thumshirn@wdc.com \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=damien.lemoal@wdc.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=jisoo2146.oh@samsung.com \
--cc=junho89.kim@samsung.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=mj0123.lee@samsung.com \
--cc=osandov@fb.com \
--cc=patchwork-bot@kernel.org \
--cc=seunghwan.hyun@samsung.com \
--cc=sookwan7.kim@samsung.com \
--cc=tj@kernel.org \
--cc=tom.leiming@gmail.com \
--cc=woosung2.lee@samsung.com \
--cc=yt0928.kim@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).