From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3120C43462 for ; Thu, 22 Apr 2021 08:29:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 70A946144A for ; Thu, 22 Apr 2021 08:29:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235216AbhDVIaW (ORCPT ); Thu, 22 Apr 2021 04:30:22 -0400 Received: from elvis.franken.de ([193.175.24.41]:36452 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230270AbhDVIaS (ORCPT ); Thu, 22 Apr 2021 04:30:18 -0400 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1lZUiU-0004Jz-00; Thu, 22 Apr 2021 10:29:42 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id B575AC0925; Thu, 22 Apr 2021 09:56:45 +0200 (CEST) Date: Thu, 22 Apr 2021 09:56:45 +0200 From: Thomas Bogendoerfer To: "Maciej W. Rozycki" Cc: "H. Nikolaus Schaller" , Arnd Bergmann , Huacai Chen , Huacai Chen , Jiaxun Yang , linux-arch@vger.kernel.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] MIPS: Avoid DIVU in `__div64_32' is result would be zero Message-ID: <20210422075645.GA5996@alpha.franken.de> References: <284CBC37-0F4F-4077-A172-7E47C90B8B43@goldelico.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 21, 2021 at 06:16:18PM +0200, Maciej W. Rozycki wrote: > On Wed, 21 Apr 2021, H. Nikolaus Schaller wrote: > > > > We already check the high part of the divident against zero to avoid the > > > > nit-picking: s/divident/dividend/ > > Umm, I find this embarassing (and I hesitated reaching for a dictionary > to double-check the spelling!). Indeed why would this be different from > subtrahend or minuend? > > Thomas, as this mistake has spread across three out of these patches, > both in change descriptions and actual code, would you mind dropping the > series from mips-next altogether and I'll respin the series with all > these issues corrected? I'm sorry, but I don't rebase mips-next and the patches have been pushed out before I received this mail. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]