From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D87EC433ED for ; Thu, 22 Apr 2021 08:33:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6053261417 for ; Thu, 22 Apr 2021 08:33:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235457AbhDVIeQ (ORCPT ); Thu, 22 Apr 2021 04:34:16 -0400 Received: from frasgout.his.huawei.com ([185.176.79.56]:2903 "EHLO frasgout.his.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235314AbhDVIeO (ORCPT ); Thu, 22 Apr 2021 04:34:14 -0400 Received: from fraeml703-chm.china.huawei.com (unknown [172.18.147.201]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4FQr9B3D19z6sl2h; Thu, 22 Apr 2021 16:26:06 +0800 (CST) Received: from lhreml710-chm.china.huawei.com (10.201.108.61) by fraeml703-chm.china.huawei.com (10.206.15.52) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Thu, 22 Apr 2021 10:33:38 +0200 Received: from localhost (10.52.123.71) by lhreml710-chm.china.huawei.com (10.201.108.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Thu, 22 Apr 2021 09:33:38 +0100 Date: Thu, 22 Apr 2021 09:32:09 +0100 From: Jonathan Cameron To: Greg Kroah-Hartman CC: , Kangjie Lu Subject: Re: [PATCH 094/190] Revert "iio: adc: fix a potential NULL pointer dereference" Message-ID: <20210422093209.00006cc5@Huawei.com> In-Reply-To: <20210421130105.1226686-95-gregkh@linuxfoundation.org> References: <20210421130105.1226686-1-gregkh@linuxfoundation.org> <20210421130105.1226686-95-gregkh@linuxfoundation.org> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.52.123.71] X-ClientProxiedBy: lhreml712-chm.china.huawei.com (10.201.108.63) To lhreml710-chm.china.huawei.com (10.201.108.61) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 21 Apr 2021 14:59:29 +0200 Greg Kroah-Hartman wrote: > This reverts commit 13814627c9658cf8382dd052bc251ee415670a55. > > Commits from @umn.edu addresses have been found to be submitted in "bad > faith" to try to test the kernel community's ability to review "known > malicious" changes. The result of these submissions can be found in a > paper published at the 42nd IEEE Symposium on Security and Privacy > entitled, "Open Source Insecurity: Stealthily Introducing > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University > of Minnesota) and Kangjie Lu (University of Minnesota). > > Because of this, all submissions from this group must be reverted from > the kernel tree and will need to be re-reviewed again to determine if > they actually are a valid fix. Until that work is complete, remove this > change to ensure that no problems are being introduced into the > codebase. > > Cc: Kangjie Lu > Cc: Jonathan Cameron > Signed-off-by: Greg Kroah-Hartman Checked. Original patch was valid. Don't mind how we handle it though. Can bring back later if it's dropped for now. Thanks, Jonathan > --- > drivers/iio/adc/mxs-lradc-adc.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/iio/adc/mxs-lradc-adc.c b/drivers/iio/adc/mxs-lradc-adc.c > index 30e29f44ebd2..7f327ae95739 100644 > --- a/drivers/iio/adc/mxs-lradc-adc.c > +++ b/drivers/iio/adc/mxs-lradc-adc.c > @@ -456,8 +456,6 @@ static int mxs_lradc_adc_trigger_init(struct iio_dev *iio) > > trig = devm_iio_trigger_alloc(&iio->dev, "%s-dev%i", iio->name, > iio->id); > - if (!trig) > - return -ENOMEM; > > trig->dev.parent = adc->dev; > iio_trigger_set_drvdata(trig, iio);