From: Lukasz Luba <lukasz.luba@arm.com>
To: linux-kernel@vger.kernel.org, daniel.lezcano@linaro.org
Cc: linux-pm@vger.kernel.org, amitk@kernel.org, rui.zhang@intel.com,
lukasz.luba@arm.com
Subject: [PATCH 2/3] thermal: fair share: use __thermal_cdev_update()
Date: Thu, 22 Apr 2021 16:36:23 +0100 [thread overview]
Message-ID: <20210422153624.6074-3-lukasz.luba@arm.com> (raw)
In-Reply-To: <20210422153624.6074-1-lukasz.luba@arm.com>
Use the new helper function and avoid unnecessery second lock/unlock,
which was present in old approach with thermal_cdev_update().
Signed-off-by: Lukasz Luba <lukasz.luba@arm.com>
---
drivers/thermal/gov_fair_share.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/thermal/gov_fair_share.c b/drivers/thermal/gov_fair_share.c
index 645432ce6365..1e5abf4822be 100644
--- a/drivers/thermal/gov_fair_share.c
+++ b/drivers/thermal/gov_fair_share.c
@@ -107,10 +107,9 @@ static int fair_share_throttle(struct thermal_zone_device *tz, int trip)
instance->target = get_target_state(tz, cdev, percentage,
cur_trip_level);
- mutex_lock(&instance->cdev->lock);
- instance->cdev->updated = false;
- mutex_unlock(&instance->cdev->lock);
- thermal_cdev_update(cdev);
+ mutex_lock(&cdev->lock);
+ __thermal_cdev_update(cdev);
+ mutex_unlock(&cdev->lock);
}
mutex_unlock(&tz->lock);
--
2.17.1
next prev parent reply other threads:[~2021-04-22 15:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-22 15:36 [PATCH 0/3] Thermal governors improvements and a fix Lukasz Luba
2021-04-22 15:36 ` [PATCH 1/3] thermal: fair share: lock thermal zone while looping over instances Lukasz Luba
2021-04-22 15:36 ` Lukasz Luba [this message]
2021-04-22 15:36 ` [PATCH 3/3] thermal: power allocator: use __thermal_cdev_update() Lukasz Luba
2021-04-22 17:31 ` [PATCH 0/3] Thermal governors improvements and a fix Daniel Lezcano
2021-04-22 17:33 ` Lukasz Luba
2021-04-22 17:36 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210422153624.6074-3-lukasz.luba@arm.com \
--to=lukasz.luba@arm.com \
--cc=amitk@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).