From: Borislav Petkov <bp@alien8.de>
To: Naoya Horiguchi <nao.horiguchi@gmail.com>
Cc: linux-mm@kvack.org, Tony Luck <tony.luck@intel.com>,
Aili Yao <yaoaili@kingsoft.com>,
Andrew Morton <akpm@linux-foundation.org>,
Oscar Salvador <osalvador@suse.de>,
David Hildenbrand <david@redhat.com>,
Andy Lutomirski <luto@kernel.org>,
Naoya Horiguchi <naoya.horiguchi@nec.com>,
Jue Wang <juew@google.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/3] mm/memory-failure: Use a mutex to avoid memory_failure() races
Date: Thu, 22 Apr 2021 19:01:18 +0200 [thread overview]
Message-ID: <20210422170118.GC7021@zn.tnic> (raw)
In-Reply-To: <20210421005728.1994268-2-nao.horiguchi@gmail.com>
On Wed, Apr 21, 2021 at 09:57:26AM +0900, Naoya Horiguchi wrote:
> From: Tony Luck <tony.luck@intel.com>
>
> There can be races when multiple CPUs consume poison from the same
> page. The first into memory_failure() atomically sets the HWPoison
> page flag and begins hunting for tasks that map this page. Eventually
> it invalidates those mappings and may send a SIGBUS to the affected
> tasks.
>
> But while all that work is going on, other CPUs see a "success"
> return code from memory_failure() and so they believe the error
> has been handled and continue executing.
>
> Fix by wrapping most of the internal parts of memory_failure() in
> a mutex.
>
> Signed-off-by: Tony Luck <tony.luck@intel.com>
> Signed-off-by: Naoya Horiguchi <naoya.horiguchi@nec.com>
> ---
> mm/memory-failure.c | 37 ++++++++++++++++++++++++-------------
> 1 file changed, 24 insertions(+), 13 deletions(-)
Reviewed-by: Borislav Petkov <bp@suse.de>
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2021-04-22 17:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-21 0:57 [PATCH v3 0/3] mm,hwpoison: fix sending SIGBUS for Action Required MCE Naoya Horiguchi
2021-04-21 0:57 ` [PATCH v3 1/3] mm/memory-failure: Use a mutex to avoid memory_failure() races Naoya Horiguchi
2021-04-22 17:01 ` Borislav Petkov [this message]
2021-04-21 0:57 ` [PATCH v3 2/3] mm,hwpoison: return -EHWPOISON when page already Naoya Horiguchi
2021-04-22 17:02 ` Borislav Petkov
2021-04-23 2:17 ` HORIGUCHI NAOYA(堀口 直也)
2021-04-21 0:57 ` [PATCH v3 3/3] mm,hwpoison: add kill_accessing_process() to find error virtual address Naoya Horiguchi
2021-04-22 17:02 ` Borislav Petkov
2021-04-23 2:18 ` HORIGUCHI NAOYA(堀口 直也)
2021-04-23 11:57 ` Borislav Petkov
2021-04-26 8:23 ` HORIGUCHI NAOYA(堀口 直也)
2021-05-07 2:10 ` [PATCH v3 0/3] mm,hwpoison: fix sending SIGBUS for Action Required MCE Luck, Tony
2021-05-07 3:37 ` Luck, Tony
2021-05-07 5:24 ` HORIGUCHI NAOYA(堀口 直也)
2021-05-07 11:14 ` Aili Yao
2021-05-07 18:02 ` Luck, Tony
2021-05-08 2:38 ` Aili Yao
2021-05-10 3:28 ` Luck, Tony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210422170118.GC7021@zn.tnic \
--to=bp@alien8.de \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=juew@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=nao.horiguchi@gmail.com \
--cc=naoya.horiguchi@nec.com \
--cc=osalvador@suse.de \
--cc=tony.luck@intel.com \
--cc=yaoaili@kingsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).