linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: dingsenjie@163.com
To: shawnguo@kernel.org, airlied@linux.ie, daniel@ffwll.ch
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	dingsenjie <dingsenjie@yulong.com>
Subject: [PATCH] gpu: drm: Use devm_platform_ioremap_resource_byname
Date: Fri, 23 Apr 2021 16:41:39 +0800	[thread overview]
Message-ID: <20210423084139.1240-1-dingsenjie@163.com> (raw)

From: dingsenjie <dingsenjie@yulong.com>

Use the devm_platform_ioremap_resource_byname() helper instead of
calling platform_get_resource_byname() and devm_ioremap_resource()
separately.

Signed-off-by: dingsenjie <dingsenjie@yulong.com>
---
 drivers/gpu/drm/zte/zx_vou.c | 16 +++++-----------
 1 file changed, 5 insertions(+), 11 deletions(-)

diff --git a/drivers/gpu/drm/zte/zx_vou.c b/drivers/gpu/drm/zte/zx_vou.c
index 904f62f..ba50ddf 100644
--- a/drivers/gpu/drm/zte/zx_vou.c
+++ b/drivers/gpu/drm/zte/zx_vou.c
@@ -764,7 +764,6 @@ static int zx_crtc_bind(struct device *dev, struct device *master, void *data)
 	struct platform_device *pdev = to_platform_device(dev);
 	struct drm_device *drm = data;
 	struct zx_vou_hw *vou;
-	struct resource *res;
 	int irq;
 	int ret;
 
@@ -772,16 +771,14 @@ static int zx_crtc_bind(struct device *dev, struct device *master, void *data)
 	if (!vou)
 		return -ENOMEM;
 
-	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "osd");
-	vou->osd = devm_ioremap_resource(dev, res);
+	vou->osd = devm_platform_ioremap_resource_byname(pdev, "osd");
 	if (IS_ERR(vou->osd)) {
 		ret = PTR_ERR(vou->osd);
 		DRM_DEV_ERROR(dev, "failed to remap osd region: %d\n", ret);
 		return ret;
 	}
 
-	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "timing_ctrl");
-	vou->timing = devm_ioremap_resource(dev, res);
+	vou->timing = devm_platform_ioremap_resource_byname(pdev, "timing_ctrl");
 	if (IS_ERR(vou->timing)) {
 		ret = PTR_ERR(vou->timing);
 		DRM_DEV_ERROR(dev, "failed to remap timing_ctrl region: %d\n",
@@ -789,16 +786,14 @@ static int zx_crtc_bind(struct device *dev, struct device *master, void *data)
 		return ret;
 	}
 
-	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "dtrc");
-	vou->dtrc = devm_ioremap_resource(dev, res);
+	vou->dtrc = devm_platform_ioremap_resource_byname(pdev, "dtrc");
 	if (IS_ERR(vou->dtrc)) {
 		ret = PTR_ERR(vou->dtrc);
 		DRM_DEV_ERROR(dev, "failed to remap dtrc region: %d\n", ret);
 		return ret;
 	}
 
-	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "vou_ctrl");
-	vou->vouctl = devm_ioremap_resource(dev, res);
+	vou->vouctl = devm_platform_ioremap_resource_byname(pdev, "vou_ctrl");
 	if (IS_ERR(vou->vouctl)) {
 		ret = PTR_ERR(vou->vouctl);
 		DRM_DEV_ERROR(dev, "failed to remap vou_ctrl region: %d\n",
@@ -806,8 +801,7 @@ static int zx_crtc_bind(struct device *dev, struct device *master, void *data)
 		return ret;
 	}
 
-	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "otfppu");
-	vou->otfppu = devm_ioremap_resource(dev, res);
+	vou->otfppu = devm_platform_ioremap_resource_byname(pdev, "otfppu");
 	if (IS_ERR(vou->otfppu)) {
 		ret = PTR_ERR(vou->otfppu);
 		DRM_DEV_ERROR(dev, "failed to remap otfppu region: %d\n", ret);
-- 
1.9.1



                 reply	other threads:[~2021-04-23  8:42 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210423084139.1240-1-dingsenjie@163.com \
    --to=dingsenjie@163.com \
    --cc=airlied@linux.ie \
    --cc=daniel@ffwll.ch \
    --cc=dingsenjie@yulong.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).