From: Kees Cook <keescook@chromium.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Masahiro Yamada <masahiroy@kernel.org>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Jean-Philippe Brucker <jean-philippe@linaro.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tools build: Fix quiet cmd indentation
Date: Fri, 23 Apr 2021 12:06:17 -0700 [thread overview]
Message-ID: <202104231158.30BC61C4F@keescook> (raw)
In-Reply-To: <YIMX164sB0CjPHUW@kernel.org>
On Fri, Apr 23, 2021 at 03:54:15PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Wed, Apr 21, 2021 at 11:58:48AM -0700, Kees Cook escreveu:
> > The tools quiet cmd output has mismatched indentation (and extra space
> > character between cmd name and target name) compared to the rest of
> > kbuild out:
> >
> > HOSTCC scripts/insert-sys-cert
> > LD /srv/code/tools/objtool/arch/x86/objtool-in.o
> > LD /srv/code/tools/objtool/libsubcmd-in.o
> > AR /srv/code/tools/objtool/libsubcmd.a
> > HOSTLD scripts/genksyms/genksyms
> > CC scripts/mod/empty.o
> > HOSTCC scripts/mod/mk_elfconfig
> > CC scripts/mod/devicetable-offsets.s
> > MKELF scripts/mod/elfconfig.h
> > HOSTCC scripts/mod/modpost.o
> > HOSTCC scripts/mod/file2alias.o
> > HOSTCC scripts/mod/sumversion.o
> > LD /srv/code/tools/objtool/objtool-in.o
> > LINK /srv/code/tools/objtool/objtool
> > HOSTLD scripts/mod/modpost
> > CC kernel/bounds.s
> >
> > Adjust to match the rest of kbuild.
>
> Is this some recent regression? I never noticed this when build perf,
> with what I have in perf/urgent:
> [...]
> It seems nicely aligned:
> [...]
> GEN /tmp/build/perf/common-cmds.h
> CC /tmp/build/perf/perf-read-vdso32
> CC /tmp/build/perf/exec-cmd.o
> MKDIR /tmp/build/perf/fd/
This is a "tools only" build. I wasn't clear enough in my commit log
(sorry, I can fix that if needed): it's mismatched with regard to the
rest of the kernel's kbuild output. (And since objtool is built out of
tools/, I see intermixed indentation on parallelized x86 builds.)
And, in fact, you can see it just in our combined email reply
quotations. The first line is a build target from the main kernel (from
my email), and the second is a build target from tools/ (from your email,
with additional email-quote-prefixing added for comparison):
> > CC scripts/mod/empty.o
> > CC /tmp/build/perf/exec-cmd.o
--------------^
(I haven't looked into what's needed to strip $(obj) from the tools/
target output, but that isn't as jarring for me as the extra space.)
I also nominate myself for "most trivial patch this week" award.
-Kees
--
Kees Cook
next prev parent reply other threads:[~2021-04-23 19:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-21 18:58 [PATCH] tools build: Fix quiet cmd indentation Kees Cook
2021-04-23 18:54 ` Arnaldo Carvalho de Melo
2021-04-23 19:06 ` Kees Cook [this message]
2021-05-17 3:00 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202104231158.30BC61C4F@keescook \
--to=keescook@chromium.org \
--cc=acme@kernel.org \
--cc=acme@redhat.com \
--cc=jean-philippe@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).