From: Jakub Kicinski <firstname.lastname@example.org> To: Oleksandr Natalenko <email@example.com> Cc: Alexander Duyck <firstname.lastname@example.org>, email@example.com, Jesse Brandeburg <firstname.lastname@example.org>, Tony Nguyen <email@example.com>, "David S. Miller" <firstname.lastname@example.org>, email@example.com, firstname.lastname@example.org Subject: Re: [igb] netconsole triggers warning in netpoll_poll_dev Date: Fri, 23 Apr 2021 15:58:36 -0700 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <firstname.lastname@example.org> On Fri, 23 Apr 2021 10:19:44 +0200 Oleksandr Natalenko wrote: > On Wed, Apr 07, 2021 at 04:06:29PM -0700, Alexander Duyck wrote: > > On Wed, Apr 7, 2021 at 11:07 AM Jakub Kicinski <email@example.com> wrote: > > > Sure, that's simplest. I wasn't sure something is supposed to prevent > > > this condition or if it's okay to cover it up. > > > > I'm pretty sure it is okay to cover it up. In this case the "budget - > > 1" is supposed to be the upper limit on what can be reported. I think > > it was assuming an unsigned value anyway. > > > > Another alternative would be to default clean_complete to !!budget. > > Then if budget is 0 clean_complete would always return false. > > So, among all the variants, which one to try? Or there was a separate > patch sent to address this? Alex's suggestion is probably best. I'm not aware of the fix being posted. Perhaps you could take over and post the patch if Intel doesn't chime in?
next prev parent reply other threads:[~2021-04-23 22:58 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-06 12:36 Oleksandr Natalenko 2021-04-06 18:48 ` Jakub Kicinski 2021-04-07 6:00 ` Oleksandr Natalenko 2021-04-07 15:37 ` Jakub Kicinski 2021-04-07 16:25 ` Alexander Duyck 2021-04-07 18:07 ` Jakub Kicinski 2021-04-07 23:06 ` Alexander Duyck 2021-04-23 8:19 ` Oleksandr Natalenko 2021-04-23 22:58 ` Jakub Kicinski [this message] 2021-04-26 6:47 ` Oleksandr Natalenko 2021-04-26 15:28 ` Alexander Duyck 2021-05-06 23:32 ` Jesse Brandeburg 2021-05-07 0:38 ` Alexander Duyck
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [igb] netconsole triggers warning in netpoll_poll_dev' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).