* [PATCH] checkpatch: fix uninitialized return value in raw_line subroutine
@ 2021-04-25 7:13 Dwaipayan Ray
0 siblings, 0 replies; only message in thread
From: Dwaipayan Ray @ 2021-04-25 7:13 UTC (permalink / raw)
To: joe; +Cc: linux-kernel, lukas.bulwahn, Dwaipayan Ray
In case the second argument to raw_line subroutine is 0,
$line remains uninitialized and is returned back to the callee.
If the callee tries to perform string concatenation with that
value, checkpatch throws an error:
Use of uninitialized value in concatenation (.) or string at
./scripts/checkpatch.pl line 1960.
Fix it by providing an empty string as the initial value
for $line.
Signed-off-by: Dwaipayan Ray <dwaipayanray1@gmail.com>
---
scripts/checkpatch.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 23697a6b1eaa..a98217360375 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1943,7 +1943,7 @@ sub raw_line {
my $offset = $linenr - 1;
$cnt++;
- my $line;
+ my $line = "";
while ($cnt) {
$line = $rawlines[$offset++];
next if (defined($line) && $line =~ /^-/);
--
2.30.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2021-04-25 7:13 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-25 7:13 [PATCH] checkpatch: fix uninitialized return value in raw_line subroutine Dwaipayan Ray
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).