linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 -next] leds: convert comma to semicolon
@ 2021-01-08  9:24 Zheng Yongjun
  2021-01-08 13:14 ` Dan Murphy
  2021-04-25 20:37 ` Pavel Machek
  0 siblings, 2 replies; 4+ messages in thread
From: Zheng Yongjun @ 2021-01-08  9:24 UTC (permalink / raw)
  To: pavel, linux-leds, linux-kernel; +Cc: dmurphy, Zheng Yongjun

Replace a comma between expression statements by a semicolon.

Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
---
 drivers/leds/leds-lm3642.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/leds/leds-lm3642.c b/drivers/leds/leds-lm3642.c
index 62c14872caf7..22035a380c4a 100644
--- a/drivers/leds/leds-lm3642.c
+++ b/drivers/leds/leds-lm3642.c
@@ -339,7 +339,7 @@ static int lm3642_probe(struct i2c_client *client,
 	chip->cdev_flash.max_brightness = 16;
 	chip->cdev_flash.brightness_set_blocking = lm3642_strobe_brightness_set;
 	chip->cdev_flash.default_trigger = "flash";
-	chip->cdev_flash.groups = lm3642_flash_groups,
+	chip->cdev_flash.groups = lm3642_flash_groups;
 	err = led_classdev_register(&client->dev, &chip->cdev_flash);
 	if (err < 0) {
 		dev_err(chip->dev, "failed to register flash\n");
@@ -351,7 +351,7 @@ static int lm3642_probe(struct i2c_client *client,
 	chip->cdev_torch.max_brightness = 8;
 	chip->cdev_torch.brightness_set_blocking = lm3642_torch_brightness_set;
 	chip->cdev_torch.default_trigger = "torch";
-	chip->cdev_torch.groups = lm3642_torch_groups,
+	chip->cdev_torch.groups = lm3642_torch_groups;
 	err = led_classdev_register(&client->dev, &chip->cdev_torch);
 	if (err < 0) {
 		dev_err(chip->dev, "failed to register torch\n");
-- 
2.22.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v2 -next] leds: convert comma to semicolon
  2021-01-08  9:24 [PATCH v2 -next] leds: convert comma to semicolon Zheng Yongjun
@ 2021-01-08 13:14 ` Dan Murphy
  2021-01-08 15:45   ` Pavel Machek
  2021-04-25 20:37 ` Pavel Machek
  1 sibling, 1 reply; 4+ messages in thread
From: Dan Murphy @ 2021-01-08 13:14 UTC (permalink / raw)
  To: Zheng Yongjun, pavel, linux-leds, linux-kernel

Hello

On 1/8/21 3:24 AM, Zheng Yongjun wrote:
> Replace a comma between expression statements by a semicolon.

Can you add a "Fixes" tag here?

Dan


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2 -next] leds: convert comma to semicolon
  2021-01-08 13:14 ` Dan Murphy
@ 2021-01-08 15:45   ` Pavel Machek
  0 siblings, 0 replies; 4+ messages in thread
From: Pavel Machek @ 2021-01-08 15:45 UTC (permalink / raw)
  To: Dan Murphy; +Cc: Zheng Yongjun, linux-leds, linux-kernel

On Fri 2021-01-08 07:14:08, Dan Murphy wrote:
> Hello
> 
> On 1/8/21 3:24 AM, Zheng Yongjun wrote:
> > Replace a comma between expression statements by a semicolon.
> 
> Can you add a "Fixes" tag here?

Don't. Its just cleanup, we don't want it in stable. Patch is fine as is.

-- 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2 -next] leds: convert comma to semicolon
  2021-01-08  9:24 [PATCH v2 -next] leds: convert comma to semicolon Zheng Yongjun
  2021-01-08 13:14 ` Dan Murphy
@ 2021-04-25 20:37 ` Pavel Machek
  1 sibling, 0 replies; 4+ messages in thread
From: Pavel Machek @ 2021-04-25 20:37 UTC (permalink / raw)
  To: Zheng Yongjun; +Cc: linux-leds, linux-kernel, dmurphy

[-- Attachment #1: Type: text/plain, Size: 206 bytes --]


On Fri 2021-01-08 17:24:46, Zheng Yongjun wrote:
> Replace a comma between expression statements by a semicolon.

Thanks, applied.
							Pavel
							
-- 
http://www.livejournal.com/~pavelmachek

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-04-25 20:37 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-08  9:24 [PATCH v2 -next] leds: convert comma to semicolon Zheng Yongjun
2021-01-08 13:14 ` Dan Murphy
2021-01-08 15:45   ` Pavel Machek
2021-04-25 20:37 ` Pavel Machek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).