From: Will Deacon <will@kernel.org>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
"David S . Miller" <davem@davemloft.net>,
linux-crypto@vger.kernel.org,
Catalin Marinas <catalin.marinas@arm.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, ardb@kernel.org
Subject: Re: [PATCH 3/4] crypto: arm64: generate *.S by Perl at build time instead of shipping them
Date: Mon, 26 Apr 2021 09:58:36 +0100 [thread overview]
Message-ID: <20210426085836.GA5802@willie-the-truck> (raw)
In-Reply-To: <20210425175734.1310191-3-masahiroy@kernel.org>
[+Ard]
On Mon, Apr 26, 2021 at 02:57:33AM +0900, Masahiro Yamada wrote:
> Generate *.S by Perl like arch/{mips,x86}/crypto/Makefile.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
>
> arch/arm64/crypto/Makefile | 9 +-
> arch/arm64/crypto/poly1305-core.S_shipped | 835 ---------
> arch/arm64/crypto/sha256-core.S_shipped | 2069 ---------------------
> arch/arm64/crypto/sha512-core.S_shipped | 1093 -----------
> 4 files changed, 3 insertions(+), 4003 deletions(-)
> delete mode 100644 arch/arm64/crypto/poly1305-core.S_shipped
> delete mode 100644 arch/arm64/crypto/sha256-core.S_shipped
> delete mode 100644 arch/arm64/crypto/sha512-core.S_shipped
What's the advantage of removing the _shipped files? We included them
originally so that we didn't require perl for the kernel build -- is that no
longer an issue?
I guess I'm just missing the justification for the change.
Cheers,
Will
next prev parent reply other threads:[~2021-04-26 8:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-25 17:57 [PATCH 1/4] crypto: arm: generate *.S by Perl at build time instead of shipping them Masahiro Yamada
2021-04-25 17:57 ` [PATCH 2/4] crypto: arm: use a pattern rule for generating *.S files Masahiro Yamada
2021-04-25 17:57 ` [PATCH 3/4] crypto: arm64: generate *.S by Perl at build time instead of shipping them Masahiro Yamada
2021-04-26 8:58 ` Will Deacon [this message]
2021-04-26 9:01 ` Ard Biesheuvel
2021-04-26 10:40 ` Masahiro Yamada
2021-04-25 17:57 ` [PATCH 4/4] crypto: arm64: use a pattern rule for generating *.S files Masahiro Yamada
2021-05-14 11:34 ` [PATCH 1/4] crypto: arm: generate *.S by Perl at build time instead of shipping them Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210426085836.GA5802@willie-the-truck \
--to=will@kernel.org \
--cc=ardb@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).