From: <patrice.chotard@foss.st.com>
To: Mark Brown <broonie@kernel.org>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Vignesh Raghavendra <vigneshr@ti.com>,
Boris Brezillon <boris.brezillon@collabora.com>,
<linux-mtd@lists.infradead.org>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
<linux-spi@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Cc: <patrice.chotard@foss.st.com>, <christophe.kerello@foss.st.com>
Subject: [PATCH 2/3] mtd: spinand: use the spi-mem poll status APIs
Date: Mon, 26 Apr 2021 16:39:33 +0200 [thread overview]
Message-ID: <20210426143934.25275-3-patrice.chotard@foss.st.com> (raw)
In-Reply-To: <20210426143934.25275-1-patrice.chotard@foss.st.com>
From: Christophe Kerello <christophe.kerello@foss.st.com>
Make use of spi-mem poll status APIs to let advanced controllers
optimize wait operations
Signed-off-by: Christophe Kerello <christophe.kerello@foss.st.com>
Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
---
drivers/mtd/nand/spi/core.c | 22 ++++++++++++++++++----
include/linux/mtd/spinand.h | 1 +
2 files changed, 19 insertions(+), 4 deletions(-)
diff --git a/drivers/mtd/nand/spi/core.c b/drivers/mtd/nand/spi/core.c
index 17f63f95f4a2..916f435257bd 100644
--- a/drivers/mtd/nand/spi/core.c
+++ b/drivers/mtd/nand/spi/core.c
@@ -475,18 +475,32 @@ static int spinand_erase_op(struct spinand_device *spinand,
static int spinand_wait(struct spinand_device *spinand, u8 *s)
{
- unsigned long timeo = jiffies + msecs_to_jiffies(400);
+ struct spi_mem_op op = SPINAND_GET_FEATURE_OP(REG_STATUS,
+ spinand->scratchbuf);
+ unsigned long timeo = jiffies + msecs_to_jiffies(SPINAND_STATUS_TIMEOUT_MS);
u8 status;
int ret;
- do {
- ret = spinand_read_status(spinand, &status);
+ ret = spi_mem_poll_status(spinand->spimem, &op, STATUS_BUSY, 0,
+ SPINAND_STATUS_TIMEOUT_MS);
+ if (ret != -EOPNOTSUPP) {
if (ret)
return ret;
+ status = *spinand->scratchbuf;
+
if (!(status & STATUS_BUSY))
goto out;
- } while (time_before(jiffies, timeo));
+ } else {
+ do {
+ ret = spinand_read_status(spinand, &status);
+ if (ret)
+ return ret;
+
+ if (!(status & STATUS_BUSY))
+ goto out;
+ } while (time_before(jiffies, timeo));
+ }
/*
* Extra read, just in case the STATUS_READY bit has changed
diff --git a/include/linux/mtd/spinand.h b/include/linux/mtd/spinand.h
index 6bb92f26833e..28ee481d96eb 100644
--- a/include/linux/mtd/spinand.h
+++ b/include/linux/mtd/spinand.h
@@ -170,6 +170,7 @@ struct spinand_op;
struct spinand_device;
#define SPINAND_MAX_ID_LEN 4
+#define SPINAND_STATUS_TIMEOUT_MS 400
/**
* struct spinand_id - SPI NAND id structure
--
2.17.1
next prev parent reply other threads:[~2021-04-26 14:39 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-26 14:39 [PATCH 0/3] MTD: spinand: Add spi_mem_poll_status() support patrice.chotard
2021-04-26 14:39 ` [PATCH 1/3] spi: spi-mem: add automatic poll status functions patrice.chotard
2021-04-26 16:26 ` Pratyush Yadav
2021-04-26 16:51 ` Mark Brown
2021-04-26 17:39 ` Pratyush Yadav
2021-04-30 14:22 ` Patrice CHOTARD
2021-04-30 15:56 ` Mark Brown
2021-05-05 7:21 ` Patrice CHOTARD
2021-04-30 14:16 ` Patrice CHOTARD
2021-04-30 16:51 ` Boris Brezillon
2021-05-03 8:47 ` Pratyush Yadav
2021-05-03 9:11 ` Boris Brezillon
2021-05-03 9:29 ` Pratyush Yadav
2021-05-03 9:52 ` Boris Brezillon
2021-05-04 7:46 ` Pratyush Yadav
2021-05-05 7:26 ` Patrice CHOTARD
2021-04-30 16:52 ` Boris Brezillon
2021-04-26 14:39 ` patrice.chotard [this message]
2021-04-26 14:39 ` [PATCH 3/3] spi: stm32-qspi: add automatic poll status feature patrice.chotard
2021-04-30 16:53 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210426143934.25275-3-patrice.chotard@foss.st.com \
--to=patrice.chotard@foss.st.com \
--cc=alexandre.torgue@foss.st.com \
--cc=boris.brezillon@collabora.com \
--cc=broonie@kernel.org \
--cc=christophe.kerello@foss.st.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=miquel.raynal@bootlin.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).