From: bkkarthik <email@example.com> To: Leon Romanovsky <firstname.lastname@example.org> Cc: "Rafael J. Wysocki" <email@example.com>, Shuah Khan <firstname.lastname@example.org>, Anupama K Patil <email@example.com>, Jaroslav Kysela <firstname.lastname@example.org>, "Rafael J. Wysocki" <email@example.com>, ACPI Devel Maling List <firstname.lastname@example.org>, Linux Kernel Mailing List <email@example.com>, Adam <firstname.lastname@example.org>, Greg Kroah-Hartman <email@example.com>, firstname.lastname@example.org, email@example.com Subject: Re: [PATCH] drivers: pnp: proc.c: Removed unnecessary varibles Date: Mon, 26 Apr 2021 23:22:54 +0530 [thread overview] Message-ID: <20210426175254.g63l272o4hnagcs2@burgerking> (raw) In-Reply-To: <YIa3H6kGFXiqWRtg@unreal> On 21/04/26 03:50PM, Leon Romanovsky wrote: > On Mon, Apr 26, 2021 at 02:00:58PM +0200, Rafael J. Wysocki wrote: > > On Mon, Apr 26, 2021 at 6:57 AM Leon Romanovsky <firstname.lastname@example.org> wrote: > > > > > > On Fri, Apr 23, 2021 at 03:08:03PM -0600, Shuah Khan wrote: > > > > On 4/22/21 12:03 PM, Anupama K Patil wrote: > > > > > de, e are two variables of the type 'struct proc_dir_entry' > > > > > which can be removed to save memory. This also fixes a coding style > > > > > issue reported by checkpatch where we are suggested to make assignment > > > > > outside the if statement. > > > > > > > > > > > > > Sounds like a reasonable change. > > > > > > It is unclear how much changes to ISA code are welcomed. If changes to ISA code aren't welcomed, should these be marked obsolete in the MAINTIANERS file? > > > > Real fixes and obvious cleanups are, not much more than that. > > While first part is easy to determine, the second one is more blurry. > > > > > > According to the Wikipedia, even Windows Vista disabled ISA PnP by default. > > > https://en.wikipedia.org/wiki/Legacy_Plug_and_Play#Specifications I wasn't aware until after this reply. Sorry about that! thanks, karthik > > > > It is indeed unclear how many systems with this interface still run > > Linux, but as long as the code is in the tree, there's nothing wrong > > with attempting to improve it. There's no assurance that all such > > patches will be applied, though. > > > > Thanks!
next prev parent reply other threads:[~2021-04-26 17:53 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-22 18:03 Anupama K Patil 2021-04-23 21:08 ` Shuah Khan 2021-04-26 4:57 ` Leon Romanovsky 2021-04-26 12:00 ` Rafael J. Wysocki 2021-04-26 12:50 ` Leon Romanovsky 2021-04-26 17:52 ` bkkarthik [this message] 2021-04-27 4:18 ` Leon Romanovsky 2021-04-28 12:12 ` Jaroslav Kysela 2021-04-28 12:17 ` Jaroslav Kysela
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210426175254.g63l272o4hnagcs2@burgerking \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH] drivers: pnp: proc.c: Removed unnecessary varibles' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions on how to clone and mirror all data and code used for this inbox