* [PATCH] drm/bridge: anx7625: Fix power on delay
@ 2021-04-27 5:53 Hsin-Yi Wang
2021-04-27 14:18 ` Neil Armstrong
0 siblings, 1 reply; 2+ messages in thread
From: Hsin-Yi Wang @ 2021-04-27 5:53 UTC (permalink / raw)
To: Robert Foss
Cc: Andrzej Hajda, Neil Armstrong, Laurent Pinchart, Jonas Karlman,
Jernej Skrabec, David Airlie, Daniel Vetter, Hsin-Yi Wang,
Xin Ji, Sam Ravnborg, dri-devel, linux-kernel
From anx7625 spec, the delay between powering on power supplies and gpio
should be larger than 10ms.
Fixes: 6c744983004e ("drm/bridge: anx7625: disable regulators when power off")
Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
---
drivers/gpu/drm/bridge/analogix/anx7625.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
index 23283ba0c4f9..0a8db745cfd5 100644
--- a/drivers/gpu/drm/bridge/analogix/anx7625.c
+++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
@@ -893,7 +893,7 @@ static void anx7625_power_on(struct anx7625_data *ctx)
usleep_range(2000, 2100);
}
- usleep_range(4000, 4100);
+ usleep_range(10000, 11000);
/* Power on pin enable */
gpiod_set_value(ctx->pdata.gpio_p_on, 1);
--
2.31.1.498.g6c1eba8ee3d-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/bridge: anx7625: Fix power on delay
2021-04-27 5:53 [PATCH] drm/bridge: anx7625: Fix power on delay Hsin-Yi Wang
@ 2021-04-27 14:18 ` Neil Armstrong
0 siblings, 0 replies; 2+ messages in thread
From: Neil Armstrong @ 2021-04-27 14:18 UTC (permalink / raw)
To: Hsin-Yi Wang, Robert Foss
Cc: Andrzej Hajda, Laurent Pinchart, Jonas Karlman, Jernej Skrabec,
David Airlie, Daniel Vetter, Xin Ji, Sam Ravnborg, dri-devel,
linux-kernel
On 27/04/2021 07:53, Hsin-Yi Wang wrote:
> From anx7625 spec, the delay between powering on power supplies and gpio
> should be larger than 10ms.
>
> Fixes: 6c744983004e ("drm/bridge: anx7625: disable regulators when power off")
> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> ---
> drivers/gpu/drm/bridge/analogix/anx7625.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> index 23283ba0c4f9..0a8db745cfd5 100644
> --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> @@ -893,7 +893,7 @@ static void anx7625_power_on(struct anx7625_data *ctx)
> usleep_range(2000, 2100);
> }
>
> - usleep_range(4000, 4100);
> + usleep_range(10000, 11000);
>
> /* Power on pin enable */
> gpiod_set_value(ctx->pdata.gpio_p_on, 1);
>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-27 14:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-27 5:53 [PATCH] drm/bridge: anx7625: Fix power on delay Hsin-Yi Wang
2021-04-27 14:18 ` Neil Armstrong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).