linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Fabio Aiuto <fabioaiuto83@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: joe@perches.com, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 00/50] staging: rtl8723bs: remove all remaining debug macros in rtw_debug.h
Date: Tue, 27 Apr 2021 14:42:56 +0200	[thread overview]
Message-ID: <20210427124255.GB1399@agape.jhs> (raw)
In-Reply-To: <YIfwL3s5hdRTCNrm@kroah.com>

On Tue, Apr 27, 2021 at 01:06:23PM +0200, Greg KH wrote:
> On Sat, Apr 24, 2021 at 11:01:43AM +0200, Fabio Aiuto wrote:
> > This patchset removes all remaining debug macros in rtw_debug.h
> > 
> > DBG_871X_SEL macro is replaced with netdev_dbg() for it does
> > a raw printk call which is not best recommended for a driver.
> > 
> > @@
> > expression sel;
> > expression list args;
> > identifier padapter;
> > identifier func;
> > @@
> > 
> > func(..., struct adapter *padapter, ...) {
> >         <...
> > -       DBG_871X_SEL(sel, args);
> > +       netdev_dbg(padapter->pnetdev, args);
> >         ...>
> > 
> > unused _DBG_871X_LEVEL macro declaration is removed.
> > 
> > Beautified register dump in core/rtw_debug.c 
> > 
> > Some code cleaning is done and all other private component tracing
> > macros are removed.
> 
> Nice work, thanks for doing all of this!  Now queued up for 5.14-rc1.
> 
> greg k-h

thank you all for helping me,

fabio

      reply	other threads:[~2021-04-27 12:43 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-24  9:01 [PATCH v2 00/50] staging: rtl8723bs: remove all remaining debug macros in rtw_debug.h Fabio Aiuto
2021-04-24  9:01 ` [PATCH v2 01/50] staging: rtl8723bs: remove unused log function Fabio Aiuto
2021-04-24  9:01 ` [PATCH v2 02/50] staging: rtl8723bs: replace DBG_871X_SEL log macro with netdev_dbg() Fabio Aiuto
2021-04-24  9:01 ` [PATCH v2 03/50] staging: rtl8723bs: add two functions to improve register dump in core/rtw_debug.c Fabio Aiuto
2021-04-24  9:01 ` [PATCH v2 04/50] staging: rtl8723bs: remove DBG_871X_SEL macro declaration Fabio Aiuto
2021-04-24  9:01 ` [PATCH v2 05/50] staging: rtl8723bs: remove unused _DBG_871X_LEVEL macro Fabio Aiuto
2021-04-24  9:01 ` [PATCH v2 06/50] staging: rtl8723bs: remove unused mac_reg_dump() function argument Fabio Aiuto
2021-04-24  9:01 ` [PATCH v2 07/50] staging: rtl8723bs: remove unused bb_reg_dump() " Fabio Aiuto
2021-04-24  9:01 ` [PATCH v2 08/50] staging: rtl8723bs: remove unused rf_reg_dump() " Fabio Aiuto
2021-04-24  9:01 ` [PATCH v2 09/50] staging: rtl8723bs: remove unused RTW_DBGDUMP macro definition Fabio Aiuto
2021-04-24  9:01 ` [PATCH v2 10/50] staging: rtl8723bs: remove all defs related to _dbgdump macro Fabio Aiuto
2021-04-24  9:01 ` [PATCH v2 11/50] staging: rtl8723bs: remove unused debug variables declarations and initialization Fabio Aiuto
2021-04-24  9:01 ` [PATCH v2 12/50] staging: rtl8723bs: remove unneeded header file include Fabio Aiuto
2021-04-24  9:01 ` [PATCH v2 13/50] staging: rtl8723bs: remove unused debug macro definitions Fabio Aiuto
2021-04-24  9:01 ` [PATCH v2 14/50] staging: rtl8723bs: remove debug macros related to core/rtw_xmit.c tracing Fabio Aiuto
2021-04-24  9:01 ` [PATCH v2 15/50] staging: rtl8723bs: remove debug macros related to os_dep/xmit_linux.c tracing Fabio Aiuto
2021-04-24  9:01 ` [PATCH v2 16/50] staging: rtl8723bs: remove debug macros related to core/rtw_recv.c tracing Fabio Aiuto
2021-04-24  9:02 ` [PATCH v2 17/50] staging: rtl8723bs: remove debug macros related to os_dep/recv_linux.c tracing Fabio Aiuto
2021-04-24  9:02 ` [PATCH v2 18/50] staging: rtl8723bs: remove debug macros related to core/rtw_mlme.c tracing Fabio Aiuto
2021-04-24  9:02 ` [PATCH v2 19/50] staging: rtl8723bs: remove debug macros related to os_dep/mlme_linux.c tracing Fabio Aiuto
2021-04-24  9:02 ` [PATCH v2 20/50] staging: rtl8723bs: move static array definition from header to .c file Fabio Aiuto
2021-04-24  9:02 ` [PATCH v2 21/50] staging: rtl8723bs: remove debug macros related to core/rtw_mlme_ext.c tracing Fabio Aiuto
2021-04-24  9:02 ` [PATCH v2 22/50] staging: rtl8723bs: remove debug macros related to core/rtw_sta_mgt.c tracing Fabio Aiuto
2021-04-24  9:02 ` [PATCH v2 23/50] staging: rtl8723bs: remove debug macros related to core/rtw_cmd.c tracing Fabio Aiuto
2021-04-24  9:02 ` [PATCH v2 24/50] staging: rtl8723bs: remove obsolete debug macro definitions Fabio Aiuto
2021-04-24  9:02 ` [PATCH v2 25/50] staging: rtl8723bs: remove debug macros related to core/rtw_io.c tracing Fabio Aiuto
2021-04-24  9:02 ` [PATCH v2 26/50] staging: rtl8723bs: remove obsolete _IO_OSDEP_C_ debug macro definition Fabio Aiuto
2021-04-24  9:02 ` [PATCH v2 27/50] staging: rtl8723bs: remove debug macros related to os_dep/os_intfs.c tracing Fabio Aiuto
2021-04-24  9:02 ` [PATCH v2 28/50] staging: rtl8723bs: remove debug macros related to core/rtw_security.c tracing Fabio Aiuto
2021-04-24  9:02 ` [PATCH v2 29/50] staging: rtl8723bs: remove debug macros related to core/rtw_eeprom.c tracing Fabio Aiuto
2021-04-24  9:02 ` [PATCH v2 30/50] staging: rtl8723bs: remove debug macros related to hal/hal_intf.c tracing Fabio Aiuto
2021-04-24  9:02 ` [PATCH v2 31/50] staging: rtl8723bs: remove debug macros related to hal/sdio_halinit.c tracing Fabio Aiuto
2021-04-24  9:02 ` [PATCH v2 32/50] staging: rtl8723bs: remove unused debug macros tied to _RTL871X_IOCTL_C_ definition Fabio Aiuto
2021-04-24  9:02 ` [PATCH v2 33/50] staging: rtl8723bs: remove unused debug macros tied to _RTL871X_IOCTL_SET_C_ definition Fabio Aiuto
2021-04-24  9:02 ` [PATCH v2 34/50] staging: rtl8723bs: remove unused debug macros tied to _RTL871X_IOCTL_QUERY_C_ definition Fabio Aiuto
2021-04-24  9:02 ` [PATCH v2 35/50] staging: rtl8723bs: remove unused debug macros tied to _RTL871X_PWRCTRL_C_ definition Fabio Aiuto
2021-04-24  9:02 ` [PATCH v2 36/50] staging: rtl8723bs: remove unused macros tied to core/rtw_pwrctrl.c debug Fabio Aiuto
2021-04-24  9:02 ` [PATCH v2 37/50] staging: rtl8723bs: remove unused macros tied to os_dep/sdio_intf.c debug Fabio Aiuto
2021-04-24  9:02 ` [PATCH v2 38/50] staging: rtl8723bs: remove unused debug macros tied to _HCI_OPS_C_ definition Fabio Aiuto
2021-04-24  9:02 ` [PATCH v2 39/50] staging: rtl8723bs: remove unused debug macros tied to hal/sdio_ops.c debug Fabio Aiuto
2021-04-24  9:02 ` [PATCH v2 40/50] staging: rtl8723bs: remove unused debug macros tied to os_dep/osdep_service.c debug Fabio Aiuto
2021-04-24  9:02 ` [PATCH v2 41/50] staging: rtl8723bs: remove unused _module_mp_ def Fabio Aiuto
2021-04-24  9:02 ` [PATCH v2 42/50] staging: rtl8723bs: remove unused macros tied to _HCI_OPS_OS_C_ definition Fabio Aiuto
2021-04-24  9:02 ` [PATCH v2 43/50] staging: rtl8723bs: remove unused macros tied to _RTL871X_IOCTL_LINUX_C definition Fabio Aiuto
2021-04-24  9:02 ` [PATCH v2 44/50] staging: rtl8723bs: remove unused macros tied to _RTL8712_CMD_C_ definition Fabio Aiuto
2021-04-24  9:02 ` [PATCH v2 45/50] staging: rtl8723bs: remove commented out macro definition Fabio Aiuto
2021-04-24  9:02 ` [PATCH v2 46/50] staging: rtl8723bs: remove unused debug macro definitions Fabio Aiuto
2021-04-24  9:02 ` [PATCH v2 47/50] staging: rtl8723bs: remove unused macros tied to core/rtw_efuse.c debug Fabio Aiuto
2021-04-24  9:02 ` [PATCH v2 48/50] staging: rtl8723bs: remove unsed debug macros tied to no particular code debug Fabio Aiuto
2021-04-24  9:02 ` [PATCH v2 49/50] staging: rtl8723bs: remove last unused debug macros Fabio Aiuto
2021-04-24  9:02 ` [PATCH v2 50/50] staging: rtl8723bs: macro DRIVER_PREFIX expands to lowercase driver name Fabio Aiuto
2021-04-27 11:04   ` Greg KH
2021-04-27 12:41     ` Fabio Aiuto
2021-04-27 14:03       ` Greg KH
2021-04-27 11:06 ` [PATCH v2 00/50] staging: rtl8723bs: remove all remaining debug macros in rtw_debug.h Greg KH
2021-04-27 12:42   ` Fabio Aiuto [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210427124255.GB1399@agape.jhs \
    --to=fabioaiuto83@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).