From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0BBEC433B4 for ; Tue, 27 Apr 2021 13:54:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7EB0761001 for ; Tue, 27 Apr 2021 13:54:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235652AbhD0NzH (ORCPT ); Tue, 27 Apr 2021 09:55:07 -0400 Received: from jabberwock.ucw.cz ([46.255.230.98]:46548 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236872AbhD0Nym (ORCPT ); Tue, 27 Apr 2021 09:54:42 -0400 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 9C3D71C0B79; Tue, 27 Apr 2021 15:53:56 +0200 (CEST) Date: Tue, 27 Apr 2021 15:53:56 +0200 From: Pavel Machek To: =?utf-8?B?eXVlY2hhby56aGFvKOi1tei2iui2hSk=?= Cc: "345351830@qq.com" <345351830@qq.com>, =?utf-8?B?UmFpbmJvdy5aaGFuZyjlvLXnjokp?= , =?utf-8?B?eXVueGlhLmxpKOadjuS6kemcnik=?= , =?utf-8?B?SmlhLlN1aSjotL7nnaIp?= , Hans de Goede , Mark Gross , "linux-kernel@vger.kernel.org" , "platform-driver-x86@vger.kernel.org" Subject: Re: [v2,1/1] adv_mix955x is a scheme that multiplexes PCA9554/PCA9555 into LED and GPIO Message-ID: <20210427135356.GA2426@duo.ucw.cz> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="r5Pyd7+fXNt84Ff3" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --r5Pyd7+fXNt84Ff3 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue 2021-04-27 08:32:05, yuechao.zhao(=E8=B5=B5=E8=B6=8A=E8=B6=85) wrote: > From: Yuechao Zhao >=20 > With this driver, we can multiplex PCA9554/PCA9555 into LED and GPIO base= d on the ACPI data of BIOS. >=20 > Signed-off-by: Yuechao Zhao > Signed-off-by: Sui Jia Please Cc LED drivers to the LED maintainers... > + > +static inline u8 amix955x_set_bit(u8 val, int led_id, enum AMIX955X_LED= =20 > +state) { > + led_id %=3D BANK_SIZE; > + > + switch (state) { > + case AMIX955X_LED_ON: > + val &=3D ~(1 << led_id); //Clear bit > + break; > + case AMIX955X_LED_OFF: > + val |=3D 1 << led_id; //Set bit > + break; > + } > + > + return val; Please check CodingStyle, avoid useless comments and check word wrapping in your email settings. Best regards, Pavel --=20 http://www.livejournal.com/~pavelmachek --r5Pyd7+fXNt84Ff3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCYIgXdAAKCRAw5/Bqldv6 8n36AKCAyk/FV6UAhuTMTRVivRmq2huMAACfa69qtKio3k+F86vekm0Ukg2KABc= =asyZ -----END PGP SIGNATURE----- --r5Pyd7+fXNt84Ff3--