From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D08AC433B4 for ; Tue, 27 Apr 2021 15:54:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 04172613DC for ; Tue, 27 Apr 2021 15:54:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237519AbhD0PzI (ORCPT ); Tue, 27 Apr 2021 11:55:08 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:21700 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236397AbhD0PzE (ORCPT ); Tue, 27 Apr 2021 11:55:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1619538860; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=F2EAyRlyPf7sFuC/hgHV65Ah6f40dk7Oz+0C6LVfX60=; b=Umcgh4d7jLM4rrJZP1qHMUA9yCzNESquu+rEWCx41UBNI3ptHWgWpTm4clIwu/hOGho70w r+2Wb3v9LT4LwwbljS6TltAyUbjIumo0wqjnlbixrE44aqhZMfTDOdMo7Helz1Vl19Cb54 KM/7zx3HHS+nPR4qbXKUsNZ4FnG1EQ8= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-318-KmdsJHh6MJO8nEhikguNgw-1; Tue, 27 Apr 2021 11:54:17 -0400 X-MC-Unique: KmdsJHh6MJO8nEhikguNgw-1 Received: by mail-qk1-f200.google.com with SMTP id c4-20020a3781040000b02902e46e29acf5so6396431qkd.22 for ; Tue, 27 Apr 2021 08:54:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=F2EAyRlyPf7sFuC/hgHV65Ah6f40dk7Oz+0C6LVfX60=; b=Iz3oqqcsCkmB3WaRSdbDZ4drA4GTXGu+rZEVq7zvqgVroP4t/AU4vA5rawcJvM8mCq 6T8XFf3HQioIj/K+jq7oIyVm8MR8wUWeudKbc89Wr1dWs3m0ywCIdU2I+jkQ+APc1kjQ naK5VJg8iz/vMiSSzWygrVciJ0HLbT91+mNwswPjjQjKGLtiYzSXen/7HyPxADyrsyV/ XITfZcJDXtuAJQhqo8Y7/4Hfq8doIGO99GJBcsPRBI79QomHZOoRwrvbDdrnEXzz7/sU U57GrrYVd5WjjYP8qkTRacfWXS2wrQLPKtBF9UeDpkvTLqzIIvWBeVX6RqUSZkcMIRVC 8Zjg== X-Gm-Message-State: AOAM532TTkMHJZH06zX5HRkW5S27scHtKYSPHO832VKOTSStHVNUqBqg OvvBYb+Og/gYm85WaPvrX1oLnSuYW3kUM2ix1H4H8oWL/XNuAB1Q6wT7dswXxUko8CJFu7oOpWw oJ/JSU9CyiKGcqKKj7M5pN+H/ X-Received: by 2002:ac8:4455:: with SMTP id m21mr11149089qtn.192.1619538857285; Tue, 27 Apr 2021 08:54:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxjPXLMKWECur9Mqt8jATos9gtIg5JYkYXdpYunNG2EodbYnflzFS1Fc8CUzF2HNgSB2Ko5hg== X-Received: by 2002:ac8:4455:: with SMTP id m21mr11149060qtn.192.1619538857004; Tue, 27 Apr 2021 08:54:17 -0700 (PDT) Received: from xz-x1 (bras-base-toroon474qw-grc-77-184-145-104-227.dsl.bell.ca. [184.145.104.227]) by smtp.gmail.com with ESMTPSA id f24sm167754qto.45.2021.04.27.08.54.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Apr 2021 08:54:16 -0700 (PDT) Date: Tue, 27 Apr 2021 11:54:14 -0400 From: Peter Xu To: Hugh Dickins Cc: Axel Rasmussen , Alexander Viro , Andrea Arcangeli , Andrew Morton , Jerome Glisse , Joe Perches , Lokesh Gidra , Mike Kravetz , Mike Rapoport , Shaohua Li , Shuah Khan , Stephen Rothwell , Wang Qing , linux-api@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, Brian Geffon , "Dr . David Alan Gilbert" , Mina Almasry , Oliver Upton Subject: Re: [PATCH v4 03/10] userfaultfd/shmem: support UFFDIO_CONTINUE for shmem Message-ID: <20210427155414.GB6820@xz-x1> References: <20210420220804.486803-1-axelrasmussen@google.com> <20210420220804.486803-4-axelrasmussen@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 26, 2021 at 07:19:58PM -0700, Hugh Dickins wrote: > On Tue, 20 Apr 2021, Axel Rasmussen wrote: > > > With this change, userspace can resolve a minor fault within a > > shmem-backed area with a UFFDIO_CONTINUE ioctl. The semantics for this > > match those for hugetlbfs - we look up the existing page in the page > > cache, and install a PTE for it. > > > > This commit introduces a new helper: mcopy_atomic_install_pte. > > > > Why handle UFFDIO_CONTINUE for shmem in mm/userfaultfd.c, instead of in > > shmem.c? The existing userfault implementation only relies on shmem.c > > for VM_SHARED VMAs. However, minor fault handling / CONTINUE work just > > fine for !VM_SHARED VMAs as well. We'd prefer to handle CONTINUE for > > shmem in one place, regardless of shared/private (to reduce code > > duplication). > > > > Why add a new mcopy_atomic_install_pte helper? A problem we have with > > continue is that shmem_mcopy_atomic_pte() and mcopy_atomic_pte() are > > *close* to what we want, but not exactly. We do want to setup the PTEs > > in a CONTINUE operation, but we don't want to e.g. allocate a new page, > > charge it (e.g. to the shmem inode), manipulate various flags, etc. Also > > we have the problem stated above: shmem_mcopy_atomic_pte() and > > mcopy_atomic_pte() both handle one-half of the problem (shared / > > private) continue cares about. So, introduce mcontinue_atomic_pte(), to > > handle all of the shmem continue cases. Introduce the helper so it > > doesn't duplicate code with mcopy_atomic_pte(). > > > > In a future commit, shmem_mcopy_atomic_pte() will also be modified to > > use this new helper. However, since this is a bigger refactor, it seems > > most clear to do it as a separate change. > > > > Signed-off-by: Axel Rasmussen > > If this "03/10" had been numbered 04/10, I would have said > Acked-by: Hugh Dickins > > But I find this new ordering incomprehensible - I'm surprised that it > even builds this way around (if it does): this patch is so much about > what has been enabled in "04/10" (references to UFFDIO_CONTINUE shmem > VMAs etc). > > Does Peter still think this way round is better? If he does, then we > shall have to compromise by asking you just to squash the two together. Hi, Hugh, Axel, I have no strong opinion. To me, UFFDIO_CONTINUE can be introduced earlier like this. As long as we don't enable the feature (which is done in the next patch), no one will be able to call it, then it looks clean. Merging them also looks good to me. Thanks, -- Peter Xu