LKML Archive on
 help / color / Atom feed
From: Feng Tang <>
To: Thomas Gleixner <>
Cc: kernel test robot <>,
	Barry Song <>,
	Ingo Molnar <>,
	LKML <>,,,,,
Subject: Re: [genirq]  cbe16f35be:  will-it-scale.per_thread_ops -5.2% regression
Date: Wed, 28 Apr 2021 13:07:58 +0800
Message-ID: <> (raw)
In-Reply-To: <>

Hi Thomas,

On Tue, Apr 27, 2021 at 01:42:12PM +0200, Thomas Gleixner wrote:
> Folks,
> On Tue, Apr 27 2021 at 17:00, kernel test robot wrote:
> > Greeting,
> >
> > FYI, we noticed a -5.2% regression of will-it-scale.per_thread_ops due to commit:
> >
> > commit: cbe16f35bee6880becca6f20d2ebf6b457148552 ("genirq: Add IRQF_NO_AUTOEN for request_irq/nmi()")
> > master
> this is the second report in the last week which makes not a lot of sense.
> And this oneis makes absolutely no sense at all.
> This commit affects request_irq() and the related variants and has
> exactly ZERO influence on anything related to that test case simply
> because.
> I seriously have to ask the question whether this test infrastructure is
> actually measuring what it claims to measure.
> As this commit clearly _cannot_ have the 'measured' side effect, this
> points to some serious issue in the tests or the test infrastructure
> itself.

0day has reported about 20 similar cases that the bisected commit has
nothing to do with the benchmark case, and we were very confused too
back then. And our debug showed many of them changed the code alignment
of kernel data or text of other modules which is relevant with the
benchmark, though some cases are not well explained yet. Following are
links of some explained cases.

And to debug code alignment case, one debug patch to force all
function address aligned to 32 bytes was merged in v5.9

09c60546f04f ./Makefile: add debug option to enable function aligned on 32 bytes

For this particular case, the commit changes the code size of
request_threaded_irq(), and many following functions' alignment
are changed.

So I extended the debug patch to force 64 bytes aligned, then
this commit will cause _no_ performance change for the same test
case on same platform.

diff --git a/Makefile b/Makefile
-KBUILD_CFLAGS += -falign-functions=32
+KBUILD_CFLAGS += -falign-functions=64

Though I don't know the detail of how exactly this code alignment
affects the case. 


> Thanks,
>         tglx

  parent reply index

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-27  9:00 kernel test robot
2021-04-27  9:20 ` Song Bao Hua (Barry Song)
2021-04-27 11:37   ` Thomas Gleixner
2021-04-27 11:42 ` Thomas Gleixner
2021-04-27 19:37   ` Thomas Gleixner
2021-04-28  8:36     ` Feng Tang
2021-04-28  5:07   ` Feng Tang [this message]
2021-04-28  7:01     ` Song Bao Hua (Barry Song)
2021-04-28  8:08       ` Feng Tang
2021-04-28  8:56         ` Thomas Gleixner
2021-04-28 15:23           ` [LKP] " Philip Li
2021-04-28 16:56             ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

LKML Archive on

Archives are clonable:
	git clone --mirror lkml/git/0.git
	git clone --mirror lkml/git/1.git
	git clone --mirror lkml/git/2.git
	git clone --mirror lkml/git/3.git
	git clone --mirror lkml/git/4.git
	git clone --mirror lkml/git/5.git
	git clone --mirror lkml/git/6.git
	git clone --mirror lkml/git/7.git
	git clone --mirror lkml/git/8.git
	git clone --mirror lkml/git/9.git
	git clone --mirror lkml/git/10.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ \
	public-inbox-index lkml

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone