From: Christoph Hellwig <hch@lst.de>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Christoph Hellwig <hch@lst.de>,
"Darrick J. Wong" <djwong@kernel.org>, Jia He <justin.he@arm.com>,
Al Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
linux-xfs <linux-xfs@vger.kernel.org>,
Dave Chinner <david@fromorbit.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Eric Sandeen <sandeen@sandeen.net>
Subject: Re: [GIT PULL] iomap: new code for 5.13-rc1
Date: Wed, 28 Apr 2021 08:17:06 +0200 [thread overview]
Message-ID: <20210428061706.GC5084@lst.de> (raw)
In-Reply-To: <CAHk-=wjrpinf=8gAjxyPoXT0jbK6-U3Urawiykh-zpxeo47Vhg@mail.gmail.com>
On Tue, Apr 27, 2021 at 01:05:13PM -0700, Linus Torvalds wrote:
> So how many _would_ be enough? IOW, what would make %pD work better
> for this case?
Preferably all.
> Why are the xfstest messages so magically different from real cases
> that they'd need to be separately distinguished, and that can't be
> done with just the final path component?
>
> If you think the message is somehow unique and the path is something
> secure and identifiable, you're very confused. file_path() is in no
> way more "secure" than using %pD4 would be, since if there's some
> actual bad actor they can put newlines etc in the pathname, they can
> do chroot() etc to make the path look anything they like.
Nothing needs to be secure. It just needs to not scare users because
they can see that the first usually two components clearly identify
this is the test file system.
next prev parent reply other threads:[~2021-04-28 6:17 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-27 2:58 [GIT PULL] iomap: new code for 5.13-rc1 Darrick J. Wong
2021-04-27 19:40 ` Linus Torvalds
2021-04-27 19:57 ` Christoph Hellwig
2021-04-27 20:05 ` Linus Torvalds
2021-04-28 6:17 ` Christoph Hellwig [this message]
2021-04-28 6:38 ` Linus Torvalds
2021-04-28 6:41 ` Christoph Hellwig
2021-04-28 7:14 ` Linus Torvalds
2021-04-28 7:38 ` Rasmus Villemoes
2021-04-28 8:47 ` Justin He
2021-04-28 16:50 ` Linus Torvalds
2021-04-29 6:39 ` Rasmus Villemoes
2021-04-29 16:45 ` Linus Torvalds
2021-04-30 3:17 ` Justin He
2021-04-30 3:21 ` Al Viro
2021-04-30 6:13 ` Justin He
2021-04-30 18:58 ` Linus Torvalds
2021-04-30 18:50 ` Eric W. Biederman
2021-04-30 19:02 ` Linus Torvalds
2021-04-29 6:43 ` Christoph Hellwig
2021-04-27 20:07 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210428061706.GC5084@lst.de \
--to=hch@lst.de \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=justin.he@arm.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).