From: Jakub Kicinski <kuba@kernel.org>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: nicolas.ferre@microchip.com, claudiu.beznea@microchip.com,
davem@davemloft.net, linux@armlinux.org.uk, palmer@dabbelt.com,
paul.walmsley@sifive.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org
Subject: Re: [PATCH] net: macb: Remove redundant assignment to w0 and queue
Date: Wed, 28 Apr 2021 12:21:06 -0700 [thread overview]
Message-ID: <20210428122106.2597718a@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <1619604188-120341-1-git-send-email-jiapeng.chong@linux.alibaba.com>
On Wed, 28 Apr 2021 18:03:08 +0800 Jiapeng Chong wrote:
> diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
> index 0f6a6cb..5f1dbc2 100644
> --- a/drivers/net/ethernet/cadence/macb_main.c
> +++ b/drivers/net/ethernet/cadence/macb_main.c
> @@ -3248,7 +3248,6 @@ static void gem_prog_cmp_regs(struct macb *bp, struct ethtool_rx_flow_spec *fs)
> /* ignore field if any masking set */
> if (tp4sp_m->ip4src == 0xFFFFFFFF) {
> /* 1st compare reg - IP source address */
> - w0 = 0;
> w1 = 0;
> w0 = tp4sp_v->ip4src;
> w1 = GEM_BFINS(T2DISMSK, 1, w1); /* 32-bit compare */
> @@ -3262,7 +3261,6 @@ static void gem_prog_cmp_regs(struct macb *bp, struct ethtool_rx_flow_spec *fs)
> /* ignore field if any masking set */
> if (tp4sp_m->ip4dst == 0xFFFFFFFF) {
> /* 2nd compare reg - IP destination address */
> - w0 = 0;
> w1 = 0;
> w0 = tp4sp_v->ip4dst;
> w1 = GEM_BFINS(T2DISMSK, 1, w1); /* 32-bit compare */
Looks like this was written like that on purpose.
> @@ -4829,7 +4827,7 @@ static int __maybe_unused macb_suspend(struct device *dev)
> {
> struct net_device *netdev = dev_get_drvdata(dev);
> struct macb *bp = netdev_priv(netdev);
> - struct macb_queue *queue = bp->queues;
> + struct macb_queue *queue;
> unsigned long flags;
> unsigned int q;
> int err;
> @@ -4916,7 +4914,7 @@ static int __maybe_unused macb_resume(struct device *dev)
> {
> struct net_device *netdev = dev_get_drvdata(dev);
> struct macb *bp = netdev_priv(netdev);
> - struct macb_queue *queue = bp->queues;
> + struct macb_queue *queue;
> unsigned long flags;
> unsigned int q;
> int err;
This chunk looks good!
Would you mind splitting the patch into two (1 - w0 assignments, and
2 - queue assignments) and reposting? We can merge the latter, the
former is up to the driver maintainer to decide.
next prev parent reply other threads:[~2021-04-28 19:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-28 10:03 [PATCH] net: macb: Remove redundant assignment to w0 and queue Jiapeng Chong
2021-04-28 16:19 ` kernel test robot
2021-04-28 19:21 ` Jakub Kicinski [this message]
2021-04-29 16:32 ` Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210428122106.2597718a@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=claudiu.beznea@microchip.com \
--cc=davem@davemloft.net \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).