From: Miaohe Lin <linmiaohe@huawei.com>
To: <akpm@linux-foundation.org>
Cc: <ziy@nvidia.com>, <william.kucharski@oracle.com>,
<willy@infradead.org>, <yang.shi@linux.alibaba.com>,
<aneesh.kumar@linux.ibm.com>, <rcampbell@nvidia.com>,
<songliubraving@fb.com>, <kirill.shutemov@linux.intel.com>,
<riel@surriel.com>, <hannes@cmpxchg.org>, <minchan@kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>,
<linmiaohe@huawei.com>
Subject: [PATCH v2 2/5] mm/huge_memory.c: use page->deferred_list
Date: Thu, 29 Apr 2021 21:26:45 +0800 [thread overview]
Message-ID: <20210429132648.305447-3-linmiaohe@huawei.com> (raw)
In-Reply-To: <20210429132648.305447-1-linmiaohe@huawei.com>
Now that we can represent the location of ->deferred_list instead of
->mapping + ->index, make use of it to improve readability.
Reviewed-by: Yang Shi <shy828301@gmail.com>
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
---
mm/huge_memory.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/mm/huge_memory.c b/mm/huge_memory.c
index 63ed6b25deaa..76ca1eb2a223 100644
--- a/mm/huge_memory.c
+++ b/mm/huge_memory.c
@@ -2868,7 +2868,7 @@ static unsigned long deferred_split_scan(struct shrinker *shrink,
spin_lock_irqsave(&ds_queue->split_queue_lock, flags);
/* Take pin on all head pages to avoid freeing them under us */
list_for_each_safe(pos, next, &ds_queue->split_queue) {
- page = list_entry((void *)pos, struct page, mapping);
+ page = list_entry((void *)pos, struct page, deferred_list);
page = compound_head(page);
if (get_page_unless_zero(page)) {
list_move(page_deferred_list(page), &list);
@@ -2883,7 +2883,7 @@ static unsigned long deferred_split_scan(struct shrinker *shrink,
spin_unlock_irqrestore(&ds_queue->split_queue_lock, flags);
list_for_each_safe(pos, next, &list) {
- page = list_entry((void *)pos, struct page, mapping);
+ page = list_entry((void *)pos, struct page, deferred_list);
if (!trylock_page(page))
goto next;
/* split_huge_page() removes page from list on success */
--
2.23.0
next prev parent reply other threads:[~2021-04-29 13:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-29 13:26 [PATCH v2 0/5] Cleanup and fixup for huge_memory Miaohe Lin
2021-04-29 13:26 ` [PATCH v2 1/5] mm/huge_memory.c: remove dedicated macro HPAGE_CACHE_INDEX_MASK Miaohe Lin
2021-04-29 14:48 ` David Hildenbrand
2021-04-30 1:39 ` Miaohe Lin
2021-04-29 13:26 ` Miaohe Lin [this message]
2021-04-29 14:52 ` [PATCH v2 2/5] mm/huge_memory.c: use page->deferred_list David Hildenbrand
2021-04-29 13:26 ` [PATCH v2 3/5] mm/huge_memory.c: add missing read-only THP checking in transparent_hugepage_enabled() Miaohe Lin
2021-04-29 14:57 ` David Hildenbrand
2021-04-29 16:23 ` Yang Shi
2021-04-30 1:57 ` Miaohe Lin
2021-04-30 7:49 ` David Hildenbrand
2021-04-30 8:20 ` Miaohe Lin
2021-04-29 13:26 ` [PATCH v2 4/5] mm/huge_memory.c: remove unnecessary tlb_remove_page_size() for huge zero pmd Miaohe Lin
2021-04-29 15:02 ` David Hildenbrand
2021-04-29 17:55 ` Yang Shi
2021-04-29 13:26 ` [PATCH v2 5/5] mm/huge_memory.c: don't discard hugepage if other processes are mapping it Miaohe Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210429132648.305447-3-linmiaohe@huawei.com \
--to=linmiaohe@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=hannes@cmpxchg.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=rcampbell@nvidia.com \
--cc=riel@surriel.com \
--cc=songliubraving@fb.com \
--cc=william.kucharski@oracle.com \
--cc=willy@infradead.org \
--cc=yang.shi@linux.alibaba.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).