From: Anand K Mistry <amistry@google.com>
To: x86@kernel.org
Cc: Anand K Mistry <amistry@google.com>,
Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>,
Ingo Molnar <mingo@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org
Subject: [PATCH v2] x86: Add a prompt for HPET_EMULATE_RTC
Date: Thu, 29 Apr 2021 16:00:17 +1000 [thread overview]
Message-ID: <20210429155950.v2.1.I2392cf11fb353d10459958100b69d93346fa167c@changeid> (raw)
This does two things:
1. Makes the option visible in menuconfig, allowing the user to easily
disable this option
2. Allows olddefconfig to respect the option if it is set in the old
.config file
It's not clear exactly why the second consequence is true, but it
appears to be because when the conf tool reads the config file, it only
respects the existing setting if the option is "visible" (see
scripts/kconfig/symbol.c:381).
Signed-off-by: Anand K Mistry <amistry@google.com>
---
This patch was previously discussed at
https://lore.kernel.org/lkml/20210204132043.1.I2392cf11fb353d10459958100b69d93346fa167c@changeid/
Sending as a v2 because a merge conflict exists with commit
3228e1dc80983 ("x86/Kconfig: Remove HPET_EMULATE_RTC depends on RTC")
Changes in v2:
- Rebase
- Fix typo in commit message
arch/x86/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 0fc82237414d..55e652aa42d1 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -896,6 +896,7 @@ config HPET_TIMER
config HPET_EMULATE_RTC
def_bool y
+ prompt "HPET RTC emulation"
depends on HPET_TIMER && (RTC_DRV_CMOS=m || RTC_DRV_CMOS=y)
# Mark as expert because too many people got it wrong.
--
2.31.1.498.g6c1eba8ee3d-goog
next reply other threads:[~2021-04-29 6:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-29 6:00 Anand K Mistry [this message]
2021-05-03 7:38 ` [PATCH v2] x86: Add a prompt for HPET_EMULATE_RTC Thomas Gleixner
2021-05-04 1:21 ` Anand K. Mistry
2021-05-04 7:55 ` Thomas Gleixner
2022-03-02 20:37 ` Raul E Rangel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210429155950.v2.1.I2392cf11fb353d10459958100b69d93346fa167c@changeid \
--to=amistry@google.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).