linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bryan Brattlof <hello@bryanbrattlof.com>
To: Fabio Aiuto <fabioaiuto83@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 02/43] staging: rlt8723bs: remove if-else blocks left empty by ODM_RT_TRACE deletion
Date: Fri, 30 Apr 2021 15:02:38 +0000	[thread overview]
Message-ID: <20210430150232.23extupxlsweecrg@bryanbrattlof.com> (raw)
In-Reply-To: <20210430144959.GA1387@agape.jhs>

On Fri, Apr 30, 2021 at 04:50:00PM +0200, Fabio Aiuto wrote:
>On Fri, Apr 30, 2021 at 02:31:08PM +0000, Bryan Brattlof wrote:
>> On Fri, Apr 30, 2021 at 09:43:20AM +0200, Fabio Aiuto wrote:
>> >remove if-else blocks left empty by ODM_RT_TRACE deletion.
>> >remove unused variables to suppress compiler warnings.
>> >
>> >Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
>> >
>>
>> Hi Fabio!
>>
>> I just wanted to point out a spelling mistake in the title 'rlt8723bs'
>> in the off chance you submit a v2.
>>
>> Way to go switching this over to netdev btw.
>
>what do you mean exactly?
>

I was just praising you for all the work you are putting into this
driver. :)

>
>> --
>> ~Bryan
>>
>
>Hi Brian,
>
>thank you! Ouch I've just sent a v2 for other issues...
>no problem I will send a v3, sorry all for spamming.
>

Don't worry about me. I would wait until Greg and others have feedback
on your v2 before sending a v3 with this minor nitpick.

--
~Bryan


  reply	other threads:[~2021-04-30 15:02 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-30  7:43 [PATCH 00/43] staging: rtl8723bs: clean up driver from private debug facilities Fabio Aiuto
2021-04-30  7:43 ` [PATCH 01/43] staging: rtl8723bs: remove ODM_RT_TRACE logs Fabio Aiuto
2021-04-30  7:43 ` [PATCH 02/43] staging: rlt8723bs: remove if-else blocks left empty by ODM_RT_TRACE deletion Fabio Aiuto
2021-04-30 14:31   ` Bryan Brattlof
2021-04-30 14:50     ` Fabio Aiuto
2021-04-30 15:02       ` Bryan Brattlof [this message]
2021-04-30 15:08         ` Fabio Aiuto
2021-04-30  7:43 ` [PATCH 03/43] staging: rtl8723bs: remove empty functions Fabio Aiuto
2021-04-30  7:43 ` [PATCH 04/43] staging: rtl8723bs: remove empty .c source file Fabio Aiuto
2021-04-30 12:51   ` kernel test robot
2021-04-30  7:43 ` [PATCH 05/43] staging: rtl8723bs: remove undefined function prototypes Fabio Aiuto
2021-04-30  7:43 ` [PATCH 06/43] staging: rtl8723bs: remove empty header file Fabio Aiuto
2021-04-30  7:43 ` [PATCH 07/43] staging: rtl8723bs: remove ODM_RT_TRACE* unused macro defs Fabio Aiuto
2021-04-30  7:43 ` [PATCH 08/43] staging: rtl8723bs: remove all commented out ODM_RT_TRACE logs Fabio Aiuto
2021-04-30  7:43 ` [PATCH 09/43] staging: rtl8723bs: replace ODM_RT_ASSERT with netdev_dbg() Fabio Aiuto
2021-04-30  7:43 ` [PATCH 10/43] staging: rtl8723bs: remove unused ODM_RT_ASSERT macro Fabio Aiuto
2021-04-30  7:43 ` [PATCH 11/43] staging: rtl8723bs: remove unused ODM_PRINT_ADDR macro Fabio Aiuto
2021-04-30  7:43 ` [PATCH 12/43] staging: rtl8723bs: remove unused ODM_dbg_trace macro Fabio Aiuto
2021-04-30  7:43 ` [PATCH 13/43] staging: rtl8723bs: remove unused ODM_dbg_enter Fabio Aiuto
2021-04-30  7:43 ` [PATCH 14/43] staging: rtl8723bs: remove unused ODM_dbg_exit macro Fabio Aiuto
2021-04-30  7:43 ` [PATCH 15/43] staging: rtl8723bs: remove empty ifdef block Fabio Aiuto
2021-04-30  7:43 ` [PATCH 16/43] staging: rtl8723bs: remove unused ASSERT macro Fabio Aiuto
2021-04-30  7:43 ` [PATCH 17/43] staging: rtl8723bs: remove empty #ifndef block Fabio Aiuto
2021-04-30  7:43 ` [PATCH 18/43] staging: rtl8723bs: remove commented out RT_ASSERT occurrences Fabio Aiuto
2021-04-30  7:43 ` [PATCH 19/43] staging: rtl8723bs: remove unused RT_PRINTK macro Fabio Aiuto
2021-04-30  7:43 ` [PATCH 20/43] staging: rtl8723bs: remove BTC_PRINT logs Fabio Aiuto
2021-04-30  7:43 ` [PATCH 21/43] staging: rtl8723bs: remove empty if-else blocks after BTC_PRINT removal Fabio Aiuto
2021-04-30  7:43 ` [PATCH 22/43] staging: rtl8723bs: remove braces around single statement in if block Fabio Aiuto
2021-04-30  7:43 ` [PATCH 23/43] staging: rtl8723bs: remove commented out BTC_PRINT logs Fabio Aiuto
2021-04-30  7:43 ` [PATCH 24/43] staging: rtl8723bs: remove BTC_PRINT macro definitions Fabio Aiuto
2021-04-30  7:43 ` [PATCH 25/43] staging: rtl8723bs: remove BTC_PRINT_ADDR " Fabio Aiuto
2021-04-30  7:43 ` [PATCH 26/43] staging: rtl8723bs: remove BTC_PRINT_DATA definitions Fabio Aiuto
2021-04-30  7:43 ` [PATCH 27/43] staging: rtl8723bs: remove BTC_PRINT_F macro definition Fabio Aiuto
2021-04-30  7:43 ` [PATCH 28/43] staging: rtl8723bs: remove empty #ifdef block Fabio Aiuto
2021-04-30  7:43 ` [PATCH 29/43] staging: rtl8723bs: remove unsed hal_btcoex_SetDBG() function Fabio Aiuto
2021-04-30  7:43 ` [PATCH 30/43] staging: rtl8723bs: remove hal_btcoex_GetDBG() function Fabio Aiuto
2021-04-30  7:43 ` [PATCH 31/43] staging: rtl8723bs: remove unnecessary halbtcoutsrc_DbgInit() function Fabio Aiuto
2021-04-30  7:43 ` [PATCH 32/43] staging: rtl8723bs: remove obsolete GLBtcDbgType array declarations Fabio Aiuto
2021-04-30  7:43 ` [PATCH 33/43] staging: rtl8723bs: remove unused enum Fabio Aiuto
2021-04-30  7:43 ` [PATCH 34/43] staging: rtl8723bs: remove obsolete debug macros Fabio Aiuto
2021-04-30  7:43 ` [PATCH 35/43] staging: rtl8723bs: remove commented out DbgPrint logs Fabio Aiuto
2021-04-30  7:43 ` [PATCH 36/43] staging: rtl8723bs: remove unused DbgPrint macro Fabio Aiuto
2021-04-30  7:43 ` [PATCH 37/43] staging: rtl8723bs: remove commented out *RT_DISP logs Fabio Aiuto
2021-04-30  7:43 ` [PATCH 38/43] staging: rtl8723bs: remove RT_DISP macro definition Fabio Aiuto
2021-04-30  7:43 ` [PATCH 39/43] staging: rtl8723bs: remove ODM_InitDebugSetting() function Fabio Aiuto
2021-04-30  7:43 ` [PATCH 40/43] staging: rtl8723bs: remove empty file Fabio Aiuto
2021-04-30 14:54   ` kernel test robot
2021-04-30  7:43 ` [PATCH 41/43] staging: rtl8723bs: remove member in dm_odm_t struct Fabio Aiuto
2021-04-30  7:44 ` [PATCH 42/43] staging: rtl8723bs: remove DebugLevel " Fabio Aiuto
2021-04-30  7:44 ` [PATCH 43/43] staging: rtl8723bs: remove odm_debug.h header file Fabio Aiuto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210430150232.23extupxlsweecrg@bryanbrattlof.com \
    --to=hello@bryanbrattlof.com \
    --cc=fabioaiuto83@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).