linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@infradead.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [git pull] work.misc
Date: Sun, 2 May 2021 18:59:46 +0100	[thread overview]
Message-ID: <20210502175946.GY1847222@casper.infradead.org> (raw)
In-Reply-To: <CAHk-=whWm_a5hHr7Xnx8NNQPq5xjs6cS+APE5k_K1K6F8Wq7eQ@mail.gmail.com>

On Sun, May 02, 2021 at 09:26:26AM -0700, Linus Torvalds wrote:
> On Sat, May 1, 2021 at 6:30 PM Al Viro <viro@zeniv.linux.org.uk> wrote:
> >
> > Mikulas Patocka (1):
> >       buffer: a small optimization in grow_buffers
> 
> Side note: if that optimization actually matters (which I doubt), we
> could just make getblk and friends take s_blocksize_bits instead of
> the block size. And avoid the whole "find first bit" thing.
> 
> As it is, we end up doing odd and broken things if anybody were to
> ever use a non-power-of-2 blocksize (we check that it's a multiple of
> the hw blocksize, we check that it's between 512 and PAGE_SIZE, but we
> don't seem to check that it's a power-of-2).

I think we have checks that the hw blocksize is a power-of-two (maybe
just in SCSI?  see sd_read_capacity())

I don't see much demand in the storage industry for non-power-of-two
sizes; I was once asked about a 12kB sector size at Intel, but when I
said "no", they didn't seem surprised.  I see interest in going smaller
(cacheline sized) for pmem and I see interest in going larger (16kB
sector sizes) for NAND.

  reply	other threads:[~2021-05-02 18:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-02  1:30 [git pull] work.misc Al Viro
2021-05-02 16:26 ` Linus Torvalds
2021-05-02 17:59   ` Matthew Wilcox [this message]
2021-05-02 18:14     ` Linus Torvalds
2021-05-02 18:32 ` pr-tracker-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210502175946.GY1847222@casper.infradead.org \
    --to=willy@infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).