From: David Miller <davem@davemloft.net>
To: lijunp213@gmail.com
Cc: msuchanek@suse.de, netdev@vger.kernel.org, mpe@ellerman.id.au,
benh@kernel.crashing.org, paulus@samba.org, drt@linux.ibm.com,
sukadev@linux.ibm.com, tlfalcon@linux.ibm.com, kuba@kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ibmvnic: remove default label from to_string switch
Date: Mon, 03 May 2021 13:47:21 -0700 (PDT) [thread overview]
Message-ID: <20210503.134721.2149322673805635760.davem@davemloft.net> (raw)
In-Reply-To: <CAOhMmr701LecfuNM+EozqbiTxFvDiXjFdY2aYeKJYaXq9kqVDg@mail.gmail.com>
From: Lijun Pan <lijunp213@gmail.com>
Date: Mon, 3 May 2021 13:21:00 -0500
> On Mon, May 3, 2021 at 5:54 AM Michal Suchanek <msuchanek@suse.de> wrote:
>>
>> This way the compiler warns when a new value is added to the enum but
>> not the string transation like:
>
> s/transation/translation/
>
> This trick works.
> Since the original code does not generate gcc warnings/errors, should
> this patch be sent to net-next as an improvement?
Yes.
next prev parent reply other threads:[~2021-05-03 20:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-03 10:23 [PATCH] ibmvnic: remove default label from to_string switch Michal Suchanek
2021-05-03 18:21 ` Lijun Pan
2021-05-03 20:47 ` David Miller [this message]
2021-05-04 5:40 ` [PATCH v2 net-next] " Michal Suchanek
2021-05-04 19:19 ` [PATCH v2 net-next resend] " Michal Suchanek
2021-05-04 19:39 ` Lijun Pan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210503.134721.2149322673805635760.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=benh@kernel.crashing.org \
--cc=drt@linux.ibm.com \
--cc=kuba@kernel.org \
--cc=lijunp213@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=msuchanek@suse.de \
--cc=netdev@vger.kernel.org \
--cc=paulus@samba.org \
--cc=sukadev@linux.ibm.com \
--cc=tlfalcon@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).