From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54A65C433B4 for ; Mon, 3 May 2021 12:50:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0ED5D6121D for ; Mon, 3 May 2021 12:50:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233787AbhECMva (ORCPT ); Mon, 3 May 2021 08:51:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:53448 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230246AbhECMv3 (ORCPT ); Mon, 3 May 2021 08:51:29 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D639860D07; Mon, 3 May 2021 12:50:35 +0000 (UTC) Date: Mon, 3 May 2021 08:50:34 -0400 From: Steven Rostedt To: brookxu Cc: mingo@redhat.com, linux-kernel@vger.kernel.org, Dave Chinner , Jens Axboe Subject: Re: [PATCH v2] trace: replace WB_REASON_FOREIGN_FLUSH with a string Message-ID: <20210503085034.0397fd54@gandalf.local.home> In-Reply-To: <1619914347-21904-1-git-send-email-brookxu.cn@gmail.com> References: <1619914347-21904-1-git-send-email-brookxu.cn@gmail.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This should go through the folks that maintain the write back trace events. -- Steve On Sun, 2 May 2021 08:12:27 +0800 brookxu wrote: > From: Chunguang Xu > > Now WB_REASON_FOREIGN_FLUSH is displayed as a number, maybe a > string is better. > > v2: replace some space with tab. > > Signed-off-by: Chunguang Xu > --- > include/trace/events/writeback.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/include/trace/events/writeback.h b/include/trace/events/writeback.h > index 1efa463..7c78c04 100644 > --- a/include/trace/events/writeback.h > +++ b/include/trace/events/writeback.h > @@ -36,7 +36,8 @@ > EM( WB_REASON_PERIODIC, "periodic") \ > EM( WB_REASON_LAPTOP_TIMER, "laptop_timer") \ > EM( WB_REASON_FS_FREE_SPACE, "fs_free_space") \ > - EMe(WB_REASON_FORKER_THREAD, "forker_thread") > + EM( WB_REASON_FORKER_THREAD, "forker_thread") \ > + EMe(WB_REASON_FOREIGN_FLUSH, "foreign_flush") > > WB_WORK_REASON >