From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1526C433ED for ; Mon, 3 May 2021 17:02:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9B86D61075 for ; Mon, 3 May 2021 17:02:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234932AbhECRDH (ORCPT ); Mon, 3 May 2021 13:03:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:44504 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234940AbhECQzN (ORCPT ); Mon, 3 May 2021 12:55:13 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3514061944; Mon, 3 May 2021 16:42:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620060156; bh=hereJ0RyJy+lofiGg9BMhXrGaktzxvAE3AhkPHBnmZk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PXjcLS7VAhkKZa1PATTzdbvcYKuDz/eDTupEEOZusuMOaJz7Inhg0nxYrSRETa49g ObngHHtTM7uJnggkZGFwZHwuPvxLaga8kv70YghLYMCZ2wKHFe20GztJpLqfYoBpfr jBw0eHzuOs3mI4HV6N1JexQ6+smFMonBsZY4pIocyWzKmoWC3kQ3Wb6JCKrMqI6Bg+ j1vYvZIOCWfl5fYZsYqBEL9TPzmtb3FJ1XnjCQrJlWDiVtzt0VXVAVQvwsEA4foCCl uQM4keNs7qCSEqdFV0M0Bo2RoYFFgHScAGfsZnA1N074Ynh/emshjaD1pFk0+sDGPW 2MTo4aje5FzRQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Yang Yingliang , Hulk Robot , Krzysztof Kozlowski , Sebastian Reichel , Sasha Levin , linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 21/31] power: supply: s3c_adc_battery: fix possible use-after-free in s3c_adc_bat_remove() Date: Mon, 3 May 2021 12:41:54 -0400 Message-Id: <20210503164204.2854178-21-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210503164204.2854178-1-sashal@kernel.org> References: <20210503164204.2854178-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yang Yingliang [ Upstream commit 68ae256945d2abe9036a7b68af4cc65aff79d5b7 ] This driver's remove path calls cancel_delayed_work(). However, that function does not wait until the work function finishes. This means that the callback function may still be running after the driver's remove function has finished, which would result in a use-after-free. Fix by calling cancel_delayed_work_sync(), which ensures that the work is properly cancelled, no longer running, and unable to re-schedule itself. Reported-by: Hulk Robot Signed-off-by: Yang Yingliang Reviewed-by: Krzysztof Kozlowski Signed-off-by: Sebastian Reichel Signed-off-by: Sasha Levin --- drivers/power/supply/s3c_adc_battery.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/power/supply/s3c_adc_battery.c b/drivers/power/supply/s3c_adc_battery.c index 0ffe5cd3abf6..06b412c43aa7 100644 --- a/drivers/power/supply/s3c_adc_battery.c +++ b/drivers/power/supply/s3c_adc_battery.c @@ -392,7 +392,7 @@ static int s3c_adc_bat_remove(struct platform_device *pdev) gpio_free(pdata->gpio_charge_finished); } - cancel_delayed_work(&bat_work); + cancel_delayed_work_sync(&bat_work); if (pdata->exit) pdata->exit(); -- 2.30.2