From: Matthew Wilcox <willy@infradead.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
outreachy-kernel@googlegroups.com,
David Kershner <david.kershner@unisys.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
sparmaintainer@unisys.com, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [Outreachy kernel] Re: [PATCH v6] staging: unisys: visorhba: Convert module from IDR to XArray
Date: Tue, 4 May 2021 12:54:11 +0100 [thread overview]
Message-ID: <20210504115411.GF1847222@casper.infradead.org> (raw)
In-Reply-To: <20210504110001.GV1981@kadam>
On Tue, May 04, 2021 at 02:00:01PM +0300, Dan Carpenter wrote:
> On Tue, May 04, 2021 at 12:07:44PM +0200, Fabio M. De Francesco wrote:
> > -static void setup_scsitaskmgmt_handles(struct idr *idrtable, spinlock_t *lock,
> > - struct uiscmdrsp *cmdrsp,
> > +static int setup_scsitaskmgmt_handles(struct xarray *xa, struct uiscmdrsp *cmdrsp,
> > wait_queue_head_t *event, int *result)
> > {
> > - /* specify the event that has to be triggered when this */
> > - /* cmd is complete */
> > - cmdrsp->scsitaskmgmt.notify_handle =
> > - simple_idr_get(idrtable, event, lock);
> > - cmdrsp->scsitaskmgmt.notifyresult_handle =
> > - simple_idr_get(idrtable, result, lock);
> > + int ret;
> > + u32 id;
> > +
> > + /* specify the event that has to be triggered when this cmd is complete */
> > + ret = xa_alloc_irq(xa, &id, event, xa_limit_32b, GFP_KERNEL);
> > + if (ret == 0)
> > + cmdrsp->scsitaskmgmt.notify_handle = id;
> > + else
> > + return ret;
>
> Reverse the condition. Always do error handling, not success handling.
> Try keep the success path at one tab indent and the failure path at two
> tab indents.
>
> ret = xa_alloc_irq(xa, &id, event, xa_limit_32b, GFP_KERNEL);
> if (ret)
> return ret;
> cmdrsp->scsitaskmgmt.notify_handle = id;
>
> ret = xa_alloc_irq(xa, &id, result, xa_limit_32b, GFP_KERNEL);
> if (ret) {
> xa_erase(xa, cmdrsp->scsitaskmgmt.notify_handle);
umm. When you put these things right next to each other, it's obvious
that should be xa_erase_irq().
> > -static void cleanup_scsitaskmgmt_handles(struct idr *idrtable,
> > +static void cleanup_scsitaskmgmt_handles(struct xarray *xa,
> > struct uiscmdrsp *cmdrsp)
> > {
> > - if (cmdrsp->scsitaskmgmt.notify_handle)
> > - idr_remove(idrtable, cmdrsp->scsitaskmgmt.notify_handle);
> > - if (cmdrsp->scsitaskmgmt.notifyresult_handle)
> > - idr_remove(idrtable, cmdrsp->scsitaskmgmt.notifyresult_handle);
> > + xa_erase(xa, cmdrsp->scsitaskmgmt.notify_handle);
> > + xa_erase(xa, cmdrsp->scsitaskmgmt.notifyresult_handle);
If this code were even run, assuming the appropriate lockdep options
were enabled, xarray would point out that you were taking a lock with
interrupts enabled that was previously taken with interrupts disabled.
That's a good thing! Because before, this code was deleting entries
from the IDR with _no_ locking.
So these should both be xa_erase_irq().
> > @@ -1096,8 +1085,6 @@ static void visorhba_remove(struct visor_device *dev)
> > scsi_remove_host(scsihost);
> > scsi_host_put(scsihost);
> >
> > - idr_destroy(&devdata->idr);
>
> Do we not have to call xa_destroy()?
Correct. We covered this in earlier iterations of this series and I
don't feel like typing out the explanation again.
prev parent reply other threads:[~2021-05-04 11:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-04 10:07 [PATCH v6] staging: unisys: visorhba: Convert module from IDR to XArray Fabio M. De Francesco
2021-05-04 11:00 ` Dan Carpenter
2021-05-04 11:54 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210504115411.GF1847222@casper.infradead.org \
--to=willy@infradead.org \
--cc=dan.carpenter@oracle.com \
--cc=daniel@ffwll.ch \
--cc=david.kershner@unisys.com \
--cc=fmdefrancesco@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy-kernel@googlegroups.com \
--cc=sparmaintainer@unisys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).