From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52B7EC433B4 for ; Tue, 4 May 2021 14:01:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2C3B36115C for ; Tue, 4 May 2021 14:01:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231347AbhEDOCk (ORCPT ); Tue, 4 May 2021 10:02:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51828 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231241AbhEDOCi (ORCPT ); Tue, 4 May 2021 10:02:38 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0C967C061574 for ; Tue, 4 May 2021 07:01:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=V4U9OF/5A5A7+ex1Qlqu0+oFqFyil+2DW5bEVur773Y=; b=pazQueOhDe2ARSKQLwocmk9zmx eUloDS38mmm+XUf0HA2b2cNeWLq8cyH8LB36OfpBrEgOo7TAHEC2wd+V3QmEp+K4JgkCErZecwCtd N/h+0hDGI8m9R6hYUgCLjZoHQebjj1W2rpDTRbPsqF7sEd8hU8z3rnLXuTGeF7GNQAHXL8pLdImnv dJEay8jYsdGVaIwCK6T2d8X8FGnpif/TdDsjpJrTbiWsX0Tb/GC373ohR+lx9NnSKXNMj/qZ6SG4W 7cZj/XqdcxEpVeCApoyutZm3gYkNT+H/Ltc83JjRkYqXh5dwEmZPmWAqKUcc69Eix1l7wbtisNT0i ZobOxktg==; Received: from willy by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1ldvbz-00GeEB-E3; Tue, 04 May 2021 14:01:23 +0000 Date: Tue, 4 May 2021 15:01:19 +0100 From: Matthew Wilcox To: "Fabio M. De Francesco" Cc: outreachy-kernel@googlegroups.com, David Kershner , Greg Kroah-Hartman , sparmaintainer@unisys.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Daniel Vetter , Dan Carpenter Subject: Re: [Outreachy kernel] Re: [PATCH v7] staging: unisys: visorhba: Convert module from IDR to XArray Message-ID: <20210504140119.GH1847222@casper.infradead.org> References: <20210504133253.32269-1-fmdefrancesco@gmail.com> <20210504134216.GG1847222@casper.infradead.org> <3550993.e1xmc6yJDa@linux.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3550993.e1xmc6yJDa@linux.local> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 04, 2021 at 03:58:02PM +0200, Fabio M. De Francesco wrote: > On Tuesday, May 4, 2021 3:42:16 PM CEST Matthew Wilcox wrote: > > On Tue, May 04, 2021 at 03:32:53PM +0200, Fabio M. De Francesco wrote: > > > Changes from v6; Added a call to xa_destroy() that I had forgotten. > > > > What? No! Go back and re-read what I wrote about this previously. > > > I remember that explanation you gave me some days ago for not using it. But I > was mislead by a comment ("Do we not have to call xa_destroy()?") by Dan and > your "Correct" soon after the above comment. So I thought that I had > misunderstand and the put back that call to xa_destroy(). I lost something in > following the flow of the reviews, I suppose. English doesn't have the equivalent of the French 'si' or German 'doch', unfortunately. I imagine Italian does.