From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: akpm@linux-foundation.org, joe@perches.com, apw@canonical.com
Cc: linux-kernel@vger.kernel.org,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Subject: [PATCH] checkpatch: do not check for "/dev/null" while parsing addition of files
Date: Wed, 5 May 2021 13:42:30 +0530 [thread overview]
Message-ID: <20210505081230.29190-1-manivannan.sadhasivam@linaro.org> (raw)
"/dev/null" is used to signal created or deleted files in the diff header.
While parsing the addition of files, checkpatch should look for
"+++ b/file" and ignore "+++ /dev/null".
Without this change, checkpatch falsely reports below warning for the
patch that does devicetree YAML conversion:
```
WARNING: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst
WARNING: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst
```
There was no includes in the patch but the warning was thrown as the logic
was messed up due to the incorrect entry to "elsif" block.
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
scripts/checkpatch.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index df8b23dc1eb0..0c201d387ca9 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2694,7 +2694,7 @@ sub process {
$realfile =~ s@^([^/]*)/@@ if (!$file);
$in_commit_log = 0;
$found_file = 1;
- } elsif ($line =~ /^\+\+\+\s+(\S+)/) {
+ } elsif ($line =~ /^\+\+\+\s+b(\S+)/) {
$realfile = $1;
$realfile =~ s@^([^/]*)/@@ if (!$file);
$in_commit_log = 0;
--
2.25.1
next reply other threads:[~2021-05-05 8:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-05 8:12 Manivannan Sadhasivam [this message]
2021-05-05 17:17 ` [PATCH] checkpatch: do not check for "/dev/null" while parsing addition of files Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210505081230.29190-1-manivannan.sadhasivam@linaro.org \
--to=manivannan.sadhasivam@linaro.org \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).