From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7651C433ED for ; Wed, 5 May 2021 12:35:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 81737613AA for ; Wed, 5 May 2021 12:35:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233302AbhEEMg2 (ORCPT ); Wed, 5 May 2021 08:36:28 -0400 Received: from frasgout.his.huawei.com ([185.176.79.56]:3029 "EHLO frasgout.his.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229793AbhEEMgY (ORCPT ); Wed, 5 May 2021 08:36:24 -0400 Received: from fraeml705-chm.china.huawei.com (unknown [172.18.147.201]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4FZwvc326Hz6rlbZ; Wed, 5 May 2021 20:27:24 +0800 (CST) Received: from lhreml710-chm.china.huawei.com (10.201.108.61) by fraeml705-chm.china.huawei.com (10.206.15.54) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Wed, 5 May 2021 14:35:26 +0200 Received: from localhost (10.52.120.138) by lhreml710-chm.china.huawei.com (10.201.108.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 5 May 2021 13:35:25 +0100 Date: Wed, 5 May 2021 13:33:46 +0100 From: Jonathan Cameron To: Mauro Carvalho Chehab CC: , , Hugues Fruchet , Mauro Carvalho Chehab , , Subject: Re: [PATCH 20/25] media: sti/delta: use pm_runtime_resume_and_get() Message-ID: <20210505133346.0000417d@Huawei.com> In-Reply-To: <20210505130158.000027d0@Huawei.com> References: <20210505130158.000027d0@Huawei.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.52.120.138] X-ClientProxiedBy: lhreml725-chm.china.huawei.com (10.201.108.76) To lhreml710-chm.china.huawei.com (10.201.108.61) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 5 May 2021 13:01:58 +0100 Jonathan Cameron wrote: > On Wed, 5 May 2021 11:42:10 +0200 > Mauro Carvalho Chehab wrote: > > > Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter") > > added pm_runtime_resume_and_get() in order to automatically handle > > dev->power.usage_count decrement on errors. > > > > Use the new API, in order to cleanup the error check logic. > > > > Signed-off-by: Mauro Carvalho Chehab > Trivial thing inline otherwise fine. > Reviewed-by: Jonathan Cameron > > --- > > drivers/media/platform/sti/delta/delta-v4l2.c | 8 +++----- > > 1 file changed, 3 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/media/platform/sti/delta/delta-v4l2.c b/drivers/media/platform/sti/delta/delta-v4l2.c > > index c691b3d81549..064a00a3084a 100644 > > --- a/drivers/media/platform/sti/delta/delta-v4l2.c > > +++ b/drivers/media/platform/sti/delta/delta-v4l2.c > > @@ -954,10 +954,8 @@ static void delta_run_work(struct work_struct *work) > > /* enable the hardware */ > > if (!dec->pm) { > > ret = delta_get_sync(ctx); > > - if (ret) { > > - delta_put_autosuspend(ctx); > > + if (ret) > > goto err; > > - } > > } > > > > /* decode this access unit */ > > @@ -1277,9 +1275,9 @@ int delta_get_sync(struct delta_ctx *ctx) > > int ret = 0; > > Loose the init > > > > > /* enable the hardware */ > > - ret = pm_runtime_get_sync(delta->dev); > > + ret = pm_runtime_resume_and_get(delta->dev); > > if (ret < 0) { > > - dev_err(delta->dev, "%s pm_runtime_get_sync failed (%d)\n", > > + dev_err(delta->dev, "%s pm_runtime_resume_and_get failed (%d)\n", > > __func__, ret); > > return ret; > > } >