linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Abel Vesa <abel.vesa@nxp.com>
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
Cc: robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de,
	kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
	p.zabel@pengutronix.de, l.stach@pengutronix.de, krzk@kernel.org,
	agx@sigxcpu.org, marex@denx.de, andrew.smirnov@gmail.com,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, ping.bai@nxp.com,
	frieder.schrempf@kontron.de, aford173@gmail.com,
	Peng Fan <peng.fan@nxp.com>
Subject: Re: [PATCH V3 1/4] dt-bindings: power: Add defines for i.MX8MM BLK-CTL power domains
Date: Thu, 6 May 2021 10:51:46 +0300	[thread overview]
Message-ID: <20210506075146.tucm2ahouzzvi3op@fsr-ub1664-175> (raw)
In-Reply-To: <20210506041555.10719-2-peng.fan@oss.nxp.com>

On 21-05-06 12:15:52, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> Adding the defines for i.MX8MM BLK-CTL power domains.
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>  include/dt-bindings/power/imx8mm-power.h | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/include/dt-bindings/power/imx8mm-power.h b/include/dt-bindings/power/imx8mm-power.h
> index fc9c2e16aadc..510e383d1953 100644
> --- a/include/dt-bindings/power/imx8mm-power.h
> +++ b/include/dt-bindings/power/imx8mm-power.h
> @@ -19,4 +19,15 @@
>  #define IMX8MM_POWER_DOMAIN_DISPMIX	10
>  #define IMX8MM_POWER_DOMAIN_MIPI	11
>  
> +#define IMX8MM_BLK_CTL_G2_PD		0
> +#define IMX8MM_BLK_CTL_G1_PD		1
> +#define IMX8MM_BLK_CTL_H1_PD		2
> +#define IMX8MM_BLK_CTL_MAX_PD		3

Put the PD before the G2, like so:

IMX8MM_BLK_CTL_PD_G2

Same for the other ones.

> +
> +#define IMX8MM_BLK_CTL_DISPMIX_CSI_BRIDGE	0
> +#define IMX8MM_BLK_CTL_DISPMIX_LCDIF		1
> +#define IMX8MM_BLK_CTL_DISPMIX_MIPI_DSI		2
> +#define IMX8MM_BLK_CTL_DISPMIX_MIPI_CSI		3
> +#define IMX8MM_BLK_CTL_DISPMIX_MAX_PD		4
> +
>  #endif
> -- 
> 2.30.0
> 

  parent reply	other threads:[~2021-05-06  7:51 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-06  4:15 [PATCH V3 0/4] soc: imx: add i.MX BLK-CTL support Peng Fan (OSS)
2021-05-06  4:15 ` [PATCH V3 1/4] dt-bindings: power: Add defines for i.MX8MM BLK-CTL power domains Peng Fan (OSS)
2021-05-06  7:15   ` Frieder Schrempf
2021-05-06  7:51   ` Abel Vesa [this message]
2021-05-06  4:15 ` [PATCH V3 2/4] Documentation: bindings: clk: Add bindings for i.MX BLK_CTL Peng Fan (OSS)
2021-05-07  1:02   ` Rob Herring
2021-05-06  4:15 ` [PATCH V3 3/4] soc: imx: Add generic blk-ctl driver Peng Fan (OSS)
2021-05-06  7:31   ` Frieder Schrempf
2021-05-06  4:15 ` [PATCH V3 4/4] soc: imx: Add blk-ctl driver for i.MX8MM Peng Fan (OSS)
2021-05-06  7:56   ` Abel Vesa
2021-05-07 12:53   ` Adam Ford
2021-05-08  0:54     ` Peng Fan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210506075146.tucm2ahouzzvi3op@fsr-ub1664-175 \
    --to=abel.vesa@nxp.com \
    --cc=aford173@gmail.com \
    --cc=agx@sigxcpu.org \
    --cc=andrew.smirnov@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=frieder.schrempf@kontron.de \
    --cc=kernel@pengutronix.de \
    --cc=krzk@kernel.org \
    --cc=l.stach@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marex@denx.de \
    --cc=p.zabel@pengutronix.de \
    --cc=peng.fan@nxp.com \
    --cc=peng.fan@oss.nxp.com \
    --cc=ping.bai@nxp.com \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).