From: Alan Stern <stern@rowland.harvard.edu>
To: chris.chiu@canonical.com
Cc: gregkh@linuxfoundation.org, m.v.b@runbox.com, hadess@hadess.net,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] USB: reset-resume the device when PORT_SUSPEND is set but timeout
Date: Fri, 7 May 2021 11:59:08 -0400 [thread overview]
Message-ID: <20210507155908.GB776548@rowland.harvard.edu> (raw)
In-Reply-To: <20210507093329.895-2-chris.chiu@canonical.com>
On Fri, May 07, 2021 at 05:33:28PM +0800, chris.chiu@canonical.com wrote:
> From: Chris Chiu <chris.chiu@canonical.com>
>
> On the Realtek hub of Dell Dock WD19, the port which has wakeup
> enabled descendants will sometimes timeout when setting PORT_SUSPEND
> feature. After checking the PORT_SUSPEND bit in wPortStatus, it is
> already set. However, the hub will fail to activate because the
> PORT_SUSPEND feature of that port is not cleared during resume. All
> devices connecting via the port are lost after resume.
>
> This commit force reset-resume the device connected to the timeout
> but suspended port so that the hub will have chance to clear the
> PORT_SUSPEND feature during resume.
>
> Signed-off-by: Chris Chiu <chris.chiu@canonical.com>
> ---
> drivers/usb/core/hub.c | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
> index b2bc4b7c4289..18603949a8de 100644
> --- a/drivers/usb/core/hub.c
> +++ b/drivers/usb/core/hub.c
> @@ -3385,6 +3385,21 @@ int usb_port_suspend(struct usb_device *udev, pm_message_t msg)
> status = 0;
> }
> if (status) {
> + if (status == -ETIMEDOUT) {
> + u16 portstatus, portchange;
> +
> + status = hub_port_status(hub, port1, &portstatus,
> + &portchange);
Don't reuse status like this. There will be a problem if this line sets
status to 0 but the port isn't actually suspended. Use a different
variable instead.
Alan Stern
> +
> + dev_dbg(&port_dev->dev,
> + "suspend timeout, status %04x\n", portstatus);
> +
> + if (status == 0 && port_is_suspended(hub, portstatus)) {
> + udev->reset_resume = 1;
> + goto err_wakeup;
> + }
> + }
> +
> dev_dbg(&port_dev->dev, "can't suspend, status %d\n", status);
>
> /* Try to enable USB3 LTM again */
> --
> 2.20.1
>
next prev parent reply other threads:[~2021-05-07 15:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-07 9:33 [PATCH 0/2] USB: propose a generic fix for PORT_SUSPEND set feature timeout chris.chiu
2021-05-07 9:33 ` [PATCH 1/2] USB: reset-resume the device when PORT_SUSPEND is set but timeout chris.chiu
2021-05-07 15:59 ` Alan Stern [this message]
2021-05-07 9:33 ` [PATCH 2/2] Revert "USB: Add reset-resume quirk for WD19's Realtek Hub" chris.chiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210507155908.GB776548@rowland.harvard.edu \
--to=stern@rowland.harvard.edu \
--cc=chris.chiu@canonical.com \
--cc=gregkh@linuxfoundation.org \
--cc=hadess@hadess.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.v.b@runbox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).