* [PATCH 1/1] drm/msm: Fix error return code in msm_drm_init()
@ 2021-05-08 2:28 Zhen Lei
2021-05-15 17:41 ` Dmitry Baryshkov
0 siblings, 1 reply; 2+ messages in thread
From: Zhen Lei @ 2021-05-08 2:28 UTC (permalink / raw)
To: Rob Clark, Sean Paul, David Airlie, Daniel Vetter,
Jeykumar Sankaran, linux-arm-msm, dri-devel, freedreno,
linux-kernel
Cc: Zhen Lei
Fix to return a negative error code from the error handling case instead
of 0, as done elsewhere in this function.
Fixes: 7f9743abaa79 ("drm/msm: validate display and event threads")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
drivers/gpu/drm/msm/msm_drv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c
index e1104d2454e2..ebd856dde1f1 100644
--- a/drivers/gpu/drm/msm/msm_drv.c
+++ b/drivers/gpu/drm/msm/msm_drv.c
@@ -523,6 +523,7 @@ static int msm_drm_init(struct device *dev, const struct drm_driver *drv)
priv->event_thread[i].worker = kthread_create_worker(0,
"crtc_event:%d", priv->event_thread[i].crtc_id);
if (IS_ERR(priv->event_thread[i].worker)) {
+ ret = PTR_ERR(priv->event_thread[i].worker);
DRM_DEV_ERROR(dev, "failed to create crtc_event kthread\n");
goto err_msm_uninit;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] drm/msm: Fix error return code in msm_drm_init()
2021-05-08 2:28 [PATCH 1/1] drm/msm: Fix error return code in msm_drm_init() Zhen Lei
@ 2021-05-15 17:41 ` Dmitry Baryshkov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Baryshkov @ 2021-05-15 17:41 UTC (permalink / raw)
To: Zhen Lei, Rob Clark, Sean Paul, David Airlie, Daniel Vetter,
Jeykumar Sankaran, linux-arm-msm, dri-devel, freedreno,
linux-kernel
On 08/05/2021 05:28, Zhen Lei wrote:
> Fix to return a negative error code from the error handling case instead
> of 0, as done elsewhere in this function.
>
> Fixes: 7f9743abaa79 ("drm/msm: validate display and event threads")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> drivers/gpu/drm/msm/msm_drv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c
> index e1104d2454e2..ebd856dde1f1 100644
> --- a/drivers/gpu/drm/msm/msm_drv.c
> +++ b/drivers/gpu/drm/msm/msm_drv.c
> @@ -523,6 +523,7 @@ static int msm_drm_init(struct device *dev, const struct drm_driver *drv)
> priv->event_thread[i].worker = kthread_create_worker(0,
> "crtc_event:%d", priv->event_thread[i].crtc_id);
> if (IS_ERR(priv->event_thread[i].worker)) {
> + ret = PTR_ERR(priv->event_thread[i].worker);
> DRM_DEV_ERROR(dev, "failed to create crtc_event kthread\n");
> goto err_msm_uninit;
> }
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-15 17:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-08 2:28 [PATCH 1/1] drm/msm: Fix error return code in msm_drm_init() Zhen Lei
2021-05-15 17:41 ` Dmitry Baryshkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).