* [PATCH] net/nfc/rawsock.c: fix a permission check bug
@ 2021-05-08 3:52 Jinmeng Zhou
2021-05-10 21:30 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Jinmeng Zhou @ 2021-05-08 3:52 UTC (permalink / raw)
To: davem, kuba; +Cc: netdev, linux-kernel, shenwenbosmile, Jeimon
From: Jeimon <jjjinmeng.zhou@gmail.com>
The function rawsock_create() calls a privileged function sk_alloc(), which requires a ns-aware check to check net->user_ns, i.e., ns_capable(). However, the original code checks the init_user_ns using capable(). So we replace the capable() with ns_capable().
Signed-off-by: Jeimon <jjjinmeng.zhou@gmail.com>
---
net/nfc/rawsock.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/nfc/rawsock.c b/net/nfc/rawsock.c
index 955c195ae..a76b62f55 100644
--- a/net/nfc/rawsock.c
+++ b/net/nfc/rawsock.c
@@ -329,7 +329,7 @@ static int rawsock_create(struct net *net, struct socket *sock,
return -ESOCKTNOSUPPORT;
if (sock->type == SOCK_RAW) {
- if (!capable(CAP_NET_RAW))
+ if (!ns_capable(net->user_ns, CAP_NET_RAW))
return -EPERM;
sock->ops = &rawsock_raw_ops;
} else {
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net/nfc/rawsock.c: fix a permission check bug
2021-05-08 3:52 [PATCH] net/nfc/rawsock.c: fix a permission check bug Jinmeng Zhou
@ 2021-05-10 21:30 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-05-10 21:30 UTC (permalink / raw)
To: Jinmeng Zhou; +Cc: davem, kuba, netdev, linux-kernel, shenwenbosmile
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Sat, 8 May 2021 11:52:30 +0800 you wrote:
> From: Jeimon <jjjinmeng.zhou@gmail.com>
>
> The function rawsock_create() calls a privileged function sk_alloc(), which requires a ns-aware check to check net->user_ns, i.e., ns_capable(). However, the original code checks the init_user_ns using capable(). So we replace the capable() with ns_capable().
>
> Signed-off-by: Jeimon <jjjinmeng.zhou@gmail.com>
> ---
> net/nfc/rawsock.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Here is the summary with links:
- net/nfc/rawsock.c: fix a permission check bug
https://git.kernel.org/netdev/net/c/8ab78863e9ef
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-10 21:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-08 3:52 [PATCH] net/nfc/rawsock.c: fix a permission check bug Jinmeng Zhou
2021-05-10 21:30 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).