From: Jonathan Cameron <jic23@kernel.org>
To: Alexandru Ardelean <aardelean@deviqon.com>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] iio: adc: mxs-lradc-adc: use iio_device_id() helper
Date: Sat, 8 May 2021 16:21:29 +0100 [thread overview]
Message-ID: <20210508162129.76a93ad1@jic23-huawei> (raw)
In-Reply-To: <20210504075304.148516-1-aardelean@deviqon.com>
On Tue, 4 May 2021 10:53:04 +0300
Alexandru Ardelean <aardelean@deviqon.com> wrote:
> The @id field was moved in commit e58bb7a74dca ("iio: core: move @id from
> struct iio_dev to struct iio_dev_opaque"), however this driver was omitted
> by accident, because the name of the IIO device is 'iio'.
>
> This was caught by the lkp bot.
>
> Fixes: e58bb7a74dca ("iio: core: move @id from struct iio_dev to struct iio_dev_opaque")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Alexandru Ardelean <aardelean@deviqon.com>
Thanks. I applied this as a fixup as that branch hadn't yet gone out as non
rebasing and I don't want to break bisection.
Also chased down how I'd missed this on in my test .config.
Jonathan
> ---
> drivers/iio/adc/mxs-lradc-adc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/mxs-lradc-adc.c b/drivers/iio/adc/mxs-lradc-adc.c
> index 30e29f44ebd2..1d99170d3328 100644
> --- a/drivers/iio/adc/mxs-lradc-adc.c
> +++ b/drivers/iio/adc/mxs-lradc-adc.c
> @@ -455,7 +455,7 @@ static int mxs_lradc_adc_trigger_init(struct iio_dev *iio)
> struct mxs_lradc_adc *adc = iio_priv(iio);
>
> trig = devm_iio_trigger_alloc(&iio->dev, "%s-dev%i", iio->name,
> - iio->id);
> + iio_device_id(iio));
> if (!trig)
> return -ENOMEM;
>
prev parent reply other threads:[~2021-05-08 15:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-04 7:53 [PATCH] iio: adc: mxs-lradc-adc: use iio_device_id() helper Alexandru Ardelean
2021-05-08 15:21 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210508162129.76a93ad1@jic23-huawei \
--to=jic23@kernel.org \
--cc=aardelean@deviqon.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).