From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E776C433B4 for ; Mon, 10 May 2021 12:52:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E8A15610FA for ; Mon, 10 May 2021 12:52:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240126AbhEJMwU (ORCPT ); Mon, 10 May 2021 08:52:20 -0400 Received: from jabberwock.ucw.cz ([46.255.230.98]:55146 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343499AbhEJMNq (ORCPT ); Mon, 10 May 2021 08:13:46 -0400 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 806821C0B79; Mon, 10 May 2021 14:12:40 +0200 (CEST) Date: Mon, 10 May 2021 14:12:40 +0200 From: Pavel Machek To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, "David E. Box" , Hans de Goede , Rajneesh Bhardwaj , Sasha Levin Subject: Re: [PATCH 5.10 108/299] platform/x86: intel_pmc_core: Dont use global pmcdev in quirks Message-ID: <20210510121240.GD3547@duo.ucw.cz> References: <20210510102004.821838356@linuxfoundation.org> <20210510102008.507160403@linuxfoundation.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="EY/WZ/HvNxOox07X" Content-Disposition: inline In-Reply-To: <20210510102008.507160403@linuxfoundation.org> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --EY/WZ/HvNxOox07X Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > From: David E. Box >=20 > [ Upstream commit c9f86d6ca6b5e23d30d16ade4b9fff5b922a610a ] >=20 > The DMI callbacks, used for quirks, currently access the PMC by getting > the address a global pmc_dev struct. Instead, have the callbacks set a > global quirk specific variable. In probe, after calling dmi_check_system(= ), > pass pmc_dev to a function that will handle each quirk if its variable > condition is met. This allows removing the global pmc_dev later. This does not fix a bug.. it is preparation for further cleanups that are not queued to 5.10 stable. So this should not be in 5.10 either. Best regards, Pavel --=20 DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany --EY/WZ/HvNxOox07X Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCYJkjOAAKCRAw5/Bqldv6 8pDnAJ9gKppI4pC9TTb4erKtW2Z4q5ES+gCgwHYngmR60ODKvSO4uoBGpmQ4X3M= =IF1o -----END PGP SIGNATURE----- --EY/WZ/HvNxOox07X--