Hi Tony,

I love your patch! Perhaps something to improve:

[auto build test WARNING on s390/features]
[also build test WARNING on linux/master linus/master v5.13-rc1 next-20210510]
[cannot apply to kvms390/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Tony-Krowiak/s390-vfio-ap-dynamic-configuration-support/20210511-004622
base:   https://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git features
config: s390-allyesconfig (attached as .config)
compiler: s390-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/0b2c602423bbdaa199a7285e28f9384fe2ac9cde
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Tony-Krowiak/s390-vfio-ap-dynamic-configuration-support/20210511-004622
        git checkout 0b2c602423bbdaa199a7285e28f9384fe2ac9cde
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross W=1 ARCH=s390 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/s390/crypto/vfio_ap_ops.c: In function 'vfio_ap_mdev_unlink_apids':
   drivers/s390/crypto/vfio_ap_ops.c:1821:4: error: implicit declaration of function 'vfio_ap_mdev_unlink_queue'; did you mean 'vfio_ap_mdev_link_queue'? [-Werror=implicit-function-declaration]
    1821 |    vfio_ap_mdev_unlink_queue(q);
         |    ^~~~~~~~~~~~~~~~~~~~~~~~~
         |    vfio_ap_mdev_link_queue
   drivers/s390/crypto/vfio_ap_ops.c: At top level:
>> drivers/s390/crypto/vfio_ap_ops.c:1914:6: warning: no previous prototype for 'vfio_ap_init_mdev_matrixes' [-Wmissing-prototypes]
    1914 | void vfio_ap_init_mdev_matrixes(struct ap_config_info *config_info)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors


vim +/vfio_ap_init_mdev_matrixes +1914 drivers/s390/crypto/vfio_ap_ops.c

  1913	
> 1914	void vfio_ap_init_mdev_matrixes(struct ap_config_info *config_info)
  1915	{
  1916		struct ap_matrix_mdev *matrix_mdev;
  1917	
  1918		list_for_each_entry(matrix_mdev, &matrix_dev->mdev_list, node) {
  1919			vfio_ap_matrix_init(config_info, &matrix_mdev->matrix);
  1920			vfio_ap_matrix_init(config_info, &matrix_mdev->shadow_apcb);
  1921		}
  1922	}
  1923	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org