From: "J. Bruce Fields" <bfields@fieldses.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "J. Bruce Fields" <bfields@redhat.com>,
linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org,
Chuck Lever <chuck.lever@oracle.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Andy Shevchenko <andy@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v3 00/15] lib/string_helpers: get rid of ugly *_escape_mem_ascii()
Date: Tue, 11 May 2021 14:57:15 -0400 [thread overview]
Message-ID: <20210511185715.GE5416@fieldses.org> (raw)
In-Reply-To: <20210504180819.73127-1-andriy.shevchenko@linux.intel.com>
These look good to me, thanks for doing this!
--b.
On Tue, May 04, 2021 at 09:08:04PM +0300, Andy Shevchenko wrote:
> Get rid of ugly *_escape_mem_ascii() API since it's not flexible and
> has the only single user. Provide better approach based on usage of the
> string_escape_mem() with appropriate flags.
>
> Test cases has been expanded accordingly to cover new functionality.
>
> This is assumed to go either thru VFS or Andrew's tree. I don't expect
> too many changes in string_helpers.
>
> Changelog v3:
> - dropped moving seq_escape() to the header due to a lot of complaints from
> the (very) old code
> - added seq_escape_str() inliner
> - converted seq_escape() to use seq_escape_str() instead of seq_escape_mem()
>
> Changelog v2:
> - introduced seq_escape_mem() instead of poking seq_get_buf() (Al)
> - to keep balance of seq_get_buf() usage, convert seq_escape() to use above
> - added missed ESCAPE_APPEND flag in NFSv4 patch
> - moved indentation patch closer to the beginning of the series
> - reshuffled series to be in two groups: generic library extension
> followed by seq_file updates
>
> Andy Shevchenko (15):
> lib/string_helpers: Switch to use BIT() macro
> lib/string_helpers: Move ESCAPE_NP check inside 'else' branch in a
> loop
> lib/string_helpers: Drop indentation level in string_escape_mem()
> lib/string_helpers: Introduce ESCAPE_NA for escaping non-ASCII
> lib/string_helpers: Introduce ESCAPE_NAP to escape non-ASCII and
> non-printable
> lib/string_helpers: Allow to append additional characters to be
> escaped
> lib/test-string_helpers: Print flags in hexadecimal format
> lib/test-string_helpers: Get rid of trailing comma in terminators
> lib/test-string_helpers: Add test cases for new features
> MAINTAINERS: Add myself as designated reviewer for generic string
> library
> seq_file: Introduce seq_escape_mem()
> seq_file: Add seq_escape_str() as replica of string_escape_str()
> seq_file: Convert seq_escape() to use seq_escape_str()
> nfsd: Avoid non-flexible API in seq_quote_mem()
> seq_file: Drop unused *_escape_mem_ascii()
>
> MAINTAINERS | 8 ++
> fs/nfsd/nfs4state.c | 2 +-
> fs/seq_file.c | 43 +++++----
> include/linux/seq_file.h | 10 ++-
> include/linux/string_helpers.h | 31 ++++---
> lib/string_helpers.c | 102 ++++++++++++---------
> lib/test-string_helpers.c | 157 +++++++++++++++++++++++++++++----
> 7 files changed, 264 insertions(+), 89 deletions(-)
>
> --
> 2.30.2
prev parent reply other threads:[~2021-05-11 18:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-04 18:08 [PATCH v3 00/15] lib/string_helpers: get rid of ugly *_escape_mem_ascii() Andy Shevchenko
2021-05-04 18:08 ` [PATCH v3 01/15] lib/string_helpers: Switch to use BIT() macro Andy Shevchenko
2021-05-04 18:08 ` [PATCH v3 02/15] lib/string_helpers: Move ESCAPE_NP check inside 'else' branch in a loop Andy Shevchenko
2021-05-04 18:08 ` [PATCH v3 03/15] lib/string_helpers: Drop indentation level in string_escape_mem() Andy Shevchenko
2021-05-04 18:08 ` [PATCH v3 04/15] lib/string_helpers: Introduce ESCAPE_NA for escaping non-ASCII Andy Shevchenko
2021-05-04 18:08 ` [PATCH v3 05/15] lib/string_helpers: Introduce ESCAPE_NAP to escape non-ASCII and non-printable Andy Shevchenko
2021-05-04 18:08 ` [PATCH v3 06/15] lib/string_helpers: Allow to append additional characters to be escaped Andy Shevchenko
2021-05-04 18:08 ` [PATCH v3 07/15] lib/test-string_helpers: Print flags in hexadecimal format Andy Shevchenko
2021-05-04 18:08 ` [PATCH v3 08/15] lib/test-string_helpers: Get rid of trailing comma in terminators Andy Shevchenko
2021-05-04 18:08 ` [PATCH v3 09/15] lib/test-string_helpers: Add test cases for new features Andy Shevchenko
2021-05-04 18:08 ` [PATCH v3 10/15] MAINTAINERS: Add myself as designated reviewer for generic string library Andy Shevchenko
2021-05-12 6:20 ` Joe Perches
2021-05-04 18:08 ` [PATCH v3 11/15] seq_file: Introduce seq_escape_mem() Andy Shevchenko
2021-05-04 18:08 ` [PATCH v3 12/15] seq_file: Add seq_escape_str() as replica of string_escape_str() Andy Shevchenko
2021-05-04 18:08 ` [PATCH v3 13/15] seq_file: Convert seq_escape() to use seq_escape_str() Andy Shevchenko
2021-05-04 18:08 ` [PATCH v3 14/15] nfsd: Avoid non-flexible API in seq_quote_mem() Andy Shevchenko
2021-05-04 18:08 ` [PATCH v3 15/15] seq_file: Drop unused *_escape_mem_ascii() Andy Shevchenko
2021-05-11 18:57 ` J. Bruce Fields [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210511185715.GE5416@fieldses.org \
--to=bfields@fieldses.org \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy@kernel.org \
--cc=bfields@redhat.com \
--cc=chuck.lever@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).