From: Viresh Kumar <viresh.kumar@linaro.org>
To: Yang Yingliang <yangyingliang@huawei.com>
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
rjw@rjwysocki.net
Subject: Re: [PATCH -next] cpufreq: cppc: Remove unnecessary INIT_LIST_HEAD()
Date: Wed, 12 May 2021 11:06:42 +0530 [thread overview]
Message-ID: <20210512053642.74so7tkzsjbthybf@vireshk-i7> (raw)
In-Reply-To: <20210511114703.3790524-1-yangyingliang@huawei.com>
On 11-05-21, 19:47, Yang Yingliang wrote:
> The list_head cpu_data_list is initialized statically.
> It is unnecessary to initialize by INIT_LIST_HEAD().
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> drivers/cpufreq/cppc_cpufreq.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/cpufreq/cppc_cpufreq.c b/drivers/cpufreq/cppc_cpufreq.c
> index 3848b4c222e1..b312fa210a39 100644
> --- a/drivers/cpufreq/cppc_cpufreq.c
> +++ b/drivers/cpufreq/cppc_cpufreq.c
> @@ -723,8 +723,6 @@ static int __init cppc_cpufreq_init(void)
> if ((acpi_disabled) || !acpi_cpc_valid())
> return -ENODEV;
>
> - INIT_LIST_HEAD(&cpu_data_list);
> -
> cppc_check_hisi_workaround();
>
> ret = cpufreq_register_driver(&cppc_cpufreq_driver);
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
prev parent reply other threads:[~2021-05-12 5:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-11 11:47 [PATCH -next] cpufreq: cppc: Remove unnecessary INIT_LIST_HEAD() Yang Yingliang
2021-05-12 5:36 ` Viresh Kumar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210512053642.74so7tkzsjbthybf@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).