From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Linux Doc Mailing List <linux-doc@vger.kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Jean Delvare <jdelvare@suse.com>,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/5] docs: hwmon: tmp103.rst: fix bad usage of UTF-8 chars
Date: Wed, 12 May 2021 07:33:30 +0200 [thread overview]
Message-ID: <20210512073330.2b48e81a@coco.lan> (raw)
In-Reply-To: <a4d0e1cf-20f1-d87c-0af6-b39f45afae5f@roeck-us.net>
Hi Guenter,
Em Tue, 11 May 2021 11:55:53 -0700
Guenter Roeck <linux@roeck-us.net> escreveu:
> On 5/11/21 8:01 AM, Mauro Carvalho Chehab wrote:
> > While UTF-8 characters can be used at the Linux documentation,
> > the best is to use them only when ASCII doesn't offer a good replacement.
> > So, replace the occurences of the following UTF-8 characters:
> >
> > - U+2013 ('–'): EN DASH
> >
> > In this specific case, EN DASH was used instead of a minus
> > sign. So, replace it by a single hyphen.
> >
> > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
>
> Confused. Is that supposed to replace the earlier patch (docs: hwmon:
> avoid using UTF-8 chars) ? I thought that was more comprehensive
> and just as valid. Anyway, should I drop that patch ?
If you applied already the previous patch, that's OK. Just ignore this
one.
It is just that, after some discussions around EM/EN DASH on
patch 00/53[1], I opted to split the changes on three parts:
- UTF-8 fixes;
- non DASH UTF-8 replacements;
- EM/EN DASH.
in order to make easier for reviewers to discuss EM/EN DASH if needed.
-
[1] You can see the full thread at:
https://lore.kernel.org/lkml/cover.1620641727.git.mchehab+huawei@kernel.org/
In summary, my original patchset were replacing both
EM/EN DASH to a single hyphen.
Yet, several maintainers seem to prefer using "--" for EN DASH
and either "--" or "---" for EM DASH.
Neither -- nor --- would make any sense on tmp103.rst, as here it
means a minus sign.
>
> Guenter
>
> > ---
> > Documentation/hwmon/tmp103.rst | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/hwmon/tmp103.rst b/Documentation/hwmon/tmp103.rst
> > index e195a7d14309..b3ef81475cf8 100644
> > --- a/Documentation/hwmon/tmp103.rst
> > +++ b/Documentation/hwmon/tmp103.rst
> > @@ -21,10 +21,10 @@ Description
> > The TMP103 is a digital output temperature sensor in a four-ball
> > wafer chip-scale package (WCSP). The TMP103 is capable of reading
> > temperatures to a resolution of 1°C. The TMP103 is specified for
> > -operation over a temperature range of –40°C to +125°C.
> > +operation over a temperature range of -40°C to +125°C.
> >
> > Resolution: 8 Bits
> > -Accuracy: ±1°C Typ (–10°C to +100°C)
> > +Accuracy: ±1°C Typ (-10°C to +100°C)
> >
> > The driver provides the common sysfs-interface for temperatures (see
> > Documentation/hwmon/sysfs-interface.rst under Temperatures).
> >
>
Thanks,
Mauro
next prev parent reply other threads:[~2021-05-12 5:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-11 15:01 [PATCH 0/5] Fix some UTF-8 bad usages Mauro Carvalho Chehab
2021-05-11 15:01 ` [PATCH 1/5] docs: cdrom-standard.rst: get rid of uneeded UTF-8 chars Mauro Carvalho Chehab
2021-05-11 15:21 ` Jens Axboe
2021-05-11 15:01 ` [PATCH 2/5] docs: ABI: remove a meaningless UTF-8 character Mauro Carvalho Chehab
2021-05-11 15:01 ` [PATCH 3/5] docs: ABI: remove some spurious characters Mauro Carvalho Chehab
2021-05-11 15:01 ` [PATCH 4/5] docs: hwmon: tmp103.rst: fix bad usage of UTF-8 chars Mauro Carvalho Chehab
2021-05-11 18:55 ` Guenter Roeck
2021-05-12 5:33 ` Mauro Carvalho Chehab [this message]
2021-05-11 15:01 ` [PATCH 5/5] docs: networking: device_drivers: " Mauro Carvalho Chehab
2021-05-11 17:22 ` Andrew Lunn
2021-05-11 18:24 ` Jonathan Corbet
2021-05-11 18:48 ` Matthew Wilcox
2021-05-11 19:10 ` Mauro Carvalho Chehab
2021-05-11 17:01 ` [PATCH 0/5] Fix some UTF-8 bad usages Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210512073330.2b48e81a@coco.lan \
--to=mchehab+huawei@kernel.org \
--cc=corbet@lwn.net \
--cc=jdelvare@suse.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).