From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 206DDC43461 for ; Thu, 13 May 2021 03:47:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EB506613F7 for ; Thu, 13 May 2021 03:47:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231175AbhEMDso (ORCPT ); Wed, 12 May 2021 23:48:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:51118 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231126AbhEMDsh (ORCPT ); Wed, 12 May 2021 23:48:37 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 10F59611AE; Thu, 13 May 2021 03:47:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620877648; bh=p6xrZ3JTKsWDJtrDHXmvV7dSY9P2McoHF8Qq23N2Hy0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RiOJMHOw7QFqZMpitICnAEodKuvl9bO6LqkcTIank8kD4vMgQXKutx5MQQIjJeD23 tEsNAoFtjyrBU0eZ1ImCY3Q1Mlj79a0vCuhGI3ur3N26xvwsPmuixwsZ9B/xOLUVgl kfP79D3HhAmDuzXTbs7P3Uqq4DZEOY/L17oXj5nSLFZoQ6ELq4yXx3mKykuvB2CmFj QNfZUIThbOnbdGm3vIP/E8IYbMUFRYlMrGtzjMNctzSStqiLbfy6fUGLiQWg5HJ57V Rb0FmsdZimyEX84vZMNq0iugQhPpJ3zLjcJ+wI5ggElXzpq/z8iW0qVweiihQpG7Rr 0ZP5qvVHQoFaA== Date: Thu, 13 May 2021 11:47:23 +0800 From: Shawn Guo To: Michal =?utf-8?B?Vm9rw6HEjQ==?= Cc: Rob Herring , Fabio Estevam , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Andrew Lunn , stable@vger.kernel.org Subject: Re: [PATCH] ARM: dts: imx6dl-yapp4: Fix RGMII connection to QCA8334 switch Message-ID: <20210513034722.GN3425@dragon> References: <1618325157-5774-1-git-send-email-michal.vokac@ysoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1618325157-5774-1-git-send-email-michal.vokac@ysoft.com> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 13, 2021 at 04:45:57PM +0200, Michal Vokáč wrote: > The FEC does not have a PHY so it should not have a phy-handle. It is > connected to the switch at RGMII level so we need a fixed-link sub-node > on both ends. > > This was not a problem until the qca8k.c driver was converted to PHYLINK > by commit b3591c2a3661 ("net: dsa: qca8k: Switch to PHYLINK instead of > PHYLIB"). That commit revealed the FEC configuration was not correct. > > Fixes: 87489ec3a77f ("ARM: dts: imx: Add Y Soft IOTA Draco, Hydra and Ursa boards") > Cc: stable@vger.kernel.org > Signed-off-by: Michal Vokáč Applied, thanks.