From: Randy Dunlap <rdunlap@infradead.org>
To: linux-kernel@vger.kernel.org
Cc: Randy Dunlap <rdunlap@infradead.org>,
Oliver Glitta <glittao@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org
Subject: [PATCH -mm] slub: STACKDEPOT: rename save_stack_trace()
Date: Wed, 12 May 2021 22:19:20 -0700 [thread overview]
Message-ID: <20210513051920.29320-1-rdunlap@infradead.org> (raw)
save_stack_trace() already exists, so change the one in
CONFIG_STACKDEPOT to be save_stack_depot_trace().
Fixes this build error:
../mm/slub.c:607:29: error: conflicting types for ‘save_stack_trace’
static depot_stack_handle_t save_stack_trace(gfp_t flags)
^~~~~~~~~~~~~~~~
In file included from ../include/linux/page_ext.h:6:0,
from ../include/linux/mm.h:25,
from ../mm/slub.c:13:
../include/linux/stacktrace.h:86:13: note: previous declaration of ‘save_stack_trace’ was here
extern void save_stack_trace(struct stack_trace *trace);
^~~~~~~~~~~~~~~~
from this patch in mmotm:
Subject: mm/slub: use stackdepot to save stack trace in objects
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Oliver Glitta <glittao@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org
---
mm/slub.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- mmotm-2021-0512-2146.orig/mm/slub.c
+++ mmotm-2021-0512-2146/mm/slub.c
@@ -604,7 +604,7 @@ static struct track *get_track(struct km
}
#ifdef CONFIG_STACKDEPOT
-static depot_stack_handle_t save_stack_trace(gfp_t flags)
+static depot_stack_handle_t save_stack_depot_trace(gfp_t flags)
{
unsigned long entries[TRACK_ADDRS_COUNT];
depot_stack_handle_t handle;
@@ -623,7 +623,7 @@ static void set_track(struct kmem_cache
if (addr) {
#ifdef CONFIG_STACKDEPOT
- p->handle = save_stack_trace(GFP_KERNEL);
+ p->handle = save_stack_depot_trace(GFP_KERNEL);
#endif
p->addr = addr;
p->cpu = smp_processor_id();
next reply other threads:[~2021-05-13 5:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-13 5:19 Randy Dunlap [this message]
2021-05-13 9:37 ` [PATCH -mm] slub: STACKDEPOT: rename save_stack_trace() Oliver Glitta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210513051920.29320-1-rdunlap@infradead.org \
--to=rdunlap@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=glittao@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).