From: Jonathan Cameron <jic23@kernel.org>
To: Alexandru Ardelean <ardeleanalex@gmail.com>
Cc: Alexandru Lazar <alazar@startmail.com>,
linux-iio <linux-iio@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] iio: adc: remove unused private data assigned with spi_set_drvdata()
Date: Thu, 13 May 2021 15:55:52 +0100 [thread overview]
Message-ID: <20210513155552.12f64241@jic23-huawei> (raw)
In-Reply-To: <CA+U=DsrSjQa-iL5FHyiwXN=Hv72jd5b99tzcNoO97ckXgiuGzA@mail.gmail.com>
On Thu, 13 May 2021 15:14:57 +0300
Alexandru Ardelean <ardeleanalex@gmail.com> wrote:
> On Thu, May 13, 2021 at 3:06 PM Alexandru Lazar <alazar@startmail.com> wrote:
> >
> >
> > > Some drivers were copied from drivers that fit the criteria described
> > > above. In any case, in order to prevent more drivers from being used as
> > > example (and have spi_set_drvdata() needlessly set), this change removes it
> > > from the IIO ADC group.
> >
> > Oh yeah, I'm pretty sure that's how I ended up adding it in the max1241
> > code, too. Code monkey presents humble apologies :-).
>
> Well, I also added one in the AD9467 driver in the same manner.
> So ¯\_(ツ)_/¯
>
All look correct to me. I'll let this sit on the list for a few days before
picking it up.
Thanks,
Jonathan
> >
> > All the best,
> > Alex
next prev parent reply other threads:[~2021-05-13 14:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-13 11:10 [PATCH] iio: adc: remove unused private data assigned with spi_set_drvdata() Alexandru Ardelean
2021-05-13 11:21 ` Alexandru Lazar
2021-05-13 12:14 ` Alexandru Ardelean
2021-05-13 14:55 ` Jonathan Cameron [this message]
2021-06-09 20:12 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210513155552.12f64241@jic23-huawei \
--to=jic23@kernel.org \
--cc=alazar@startmail.com \
--cc=ardeleanalex@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).