From: Jonathan Cameron <jic23@kernel.org>
To: Stephan Gerhold <stephan@gerhold.net>
Cc: "Lars-Peter Clausen" <lars@metafoo.de>,
"Rob Herring" <robh+dt@kernel.org>,
"Robert Yang" <decatf@gmail.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Michał Mirosław" <mirq-linux@rere.qmqm.pl>,
"Srinivas Pandruvada" <srinivas.pandruvada@linux.intel.com>,
~postmarketos/upstreaming@lists.sr.ht,
"Hans de Goede" <hdegoede@redhat.com>
Subject: Re: [PATCH v2 0/3] iio: accel: kxcjk-1013: Add support for KX023-1025
Date: Thu, 13 May 2021 17:18:55 +0100 [thread overview]
Message-ID: <20210513171855.4bbeca6b@jic23-huawei> (raw)
In-Reply-To: <20210511142402.4457-1-stephan@gerhold.net>
On Tue, 11 May 2021 16:23:59 +0200
Stephan Gerhold <stephan@gerhold.net> wrote:
> KX023-1025 [1] is another accelerometer from Kionix that has lots
> of additional functionality compared to KXCJK-1013. It combines the
> motion interrupt functionality from KXCJK with the tap detection
> from KXTF9, plus a lot more other functionality.
>
> This patch set does not add support for any of the extra functionality,
> but makes basic functionality work with the existing kxcjk-1013 driver.
>
> At first, the register map for the KX023-1025 seems quite different
> from the other accelerometers supported by the kxcjk-1013.
> However, it turns out that at least most of the register bits
> still mean the same for KX023-1025.
>
> This patch set refactors the kxcjk-1013 driver a little bit
> to get the register addresses from a chip-specific struct.
> The register bits can be re-used for all the different chips.
>
> The KX023-1025 is used in several smartphones from Huawei.
> I tested these changes on a Huawei Ascend G7, someone else reported
> they also work fine on the Huawei Honor 5X (codename "kiwi").
>
> [1]: https://kionixfs.azureedge.net/en/datasheet/KX023-1025%20Specifications%20Rev%2012.0.pdf
Series applied to the togreg branch of iio.git and pushed out as testing
for the bots to see if they can find anything we missed.
Thanks,
Jonathan
> ---
> Changes in v2:
> - Make register structs static (reported by kernel test robot)
>
> Stephan Gerhold (3):
> dt-bindings: iio: kionix,kxcjk1013: Document kionix,kx023-1025
> iio: accel: kxcjk-1013: Refactor configuration registers into struct
> iio: accel: kxcjk-1013: Add support for KX023-1025
>
> .../bindings/iio/accel/kionix,kxcjk1013.yaml | 1 +
> drivers/iio/accel/kxcjk-1013.c | 217 ++++++++++++++----
> 2 files changed, 176 insertions(+), 42 deletions(-)
>
prev parent reply other threads:[~2021-05-13 16:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-11 14:23 [PATCH v2 0/3] iio: accel: kxcjk-1013: Add support for KX023-1025 Stephan Gerhold
2021-05-11 14:24 ` [PATCH v2 1/3] dt-bindings: iio: kionix,kxcjk1013: Document kionix,kx023-1025 Stephan Gerhold
2021-05-11 19:47 ` Rob Herring
2021-05-11 14:24 ` [PATCH v2 2/3] iio: accel: kxcjk-1013: Refactor configuration registers into struct Stephan Gerhold
2021-05-11 14:24 ` [PATCH v2 3/3] iio: accel: kxcjk-1013: Add support for KX023-1025 Stephan Gerhold
2021-05-13 16:18 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210513171855.4bbeca6b@jic23-huawei \
--to=jic23@kernel.org \
--cc=decatf@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=hdegoede@redhat.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mirq-linux@rere.qmqm.pl \
--cc=robh+dt@kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=stephan@gerhold.net \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).