From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A4DAC43460 for ; Fri, 14 May 2021 09:32:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3888D61407 for ; Fri, 14 May 2021 09:32:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231503AbhENJd7 (ORCPT ); Fri, 14 May 2021 05:33:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42006 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230440AbhENJd6 (ORCPT ); Fri, 14 May 2021 05:33:58 -0400 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C40FAC061574 for ; Fri, 14 May 2021 02:32:46 -0700 (PDT) Received: by mail-ej1-x629.google.com with SMTP id j14so2446450ejy.1 for ; Fri, 14 May 2021 02:32:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=deviqon.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=5dkvYwQ8CxkFUQyQjEPLhL9qrknOLCMJxEkbIJ8p7Y0=; b=d8nrf1ZEXN+YlTdYR7CzId6MkTm2bgp/XSLkF1P3iju9JCjVKlOe8XCQn+EzfInSri KPoqeZoKROzo9jwPli15zjn2AW+VVCIqxveeuMGNr8vBw2t8LSHB5WZNJb23+vjPnRq+ 2D4AbW3CXw2Top2DUHUhIiD8Tq5O9R2HKH+VSjCKH/HNE1mystBLrMCF5VrS1Aep0qAK bOGsmDJvL9LOkFTzjH1MdHMvo6j/7WPZ9jDUvw7ETMKUfv4MpgL2wyaZpqgJQvCpux8v gmx+NJMmwhjuEqPmOeS7TqhYBan554QKf/Z+YmQ1XZxpTXDgc88Oc+NuXYQMOPau1ITb MXJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=5dkvYwQ8CxkFUQyQjEPLhL9qrknOLCMJxEkbIJ8p7Y0=; b=nciDl/Jglcm/mrcFdZzjtluUhMkfyp2PMYTBm8dOtsVh1UHJ8J/Qf6a9AUdsnEMuNn q1CrCIqEwzNEHHWNAHWX42VsDUu3245hcHF0XhDFz2iQu3ZVczntKDEaTxjxpyHwArTI 2z15JIyjwzN1kwYdyOvwdwg+XmObkW4sGPoVdwTG8P+9QaUoQPLOLBA4wr3xMvqJXG5g kiu61Gm3axIelNfnAO/LiI+c8SgNj39Fx0Ex9aKhfAVWD0mWgO/79R5s2iNJ9iBlKHdv PDMxYh2O965/eyynQWAWCZQOG6VYWvRV3oPecvUNTzDTdnR3bZzIs2NJBgEamnEYhEFp jInw== X-Gm-Message-State: AOAM531VXaAng9zFD7MtUn+UgbUsuOp0Grc/a9rmKKJnteWZrBlViuKA ump+R8ZdyPm/vXR5XOzl5o6IVA== X-Google-Smtp-Source: ABdhPJxK3ofuQ149WFqgphHtPVKXcZBh/6pjFirMjY0I2Er9Z9n9PHIhQV2aL/R+tNFcFuzITWJZLQ== X-Received: by 2002:a17:906:e105:: with SMTP id gj5mr49528017ejb.388.1620984765596; Fri, 14 May 2021 02:32:45 -0700 (PDT) Received: from neptune.. ([5.2.193.191]) by smtp.gmail.com with ESMTPSA id r10sm3250024ejd.112.2021.05.14.02.32.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 May 2021 02:32:45 -0700 (PDT) From: Alexandru Ardelean To: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: linus.walleij@linaro.org, bgolaszewski@baylibre.com, andy@kernel.org, Alexandru Ardelean Subject: [PATCH] gpio: gpio-crystalcove: remove platform_set_drvdata() + cleanup probe Date: Fri, 14 May 2021 12:32:26 +0300 Message-Id: <20210514093226.22703-1-aardelean@deviqon.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The platform_set_drvdata() call is only useful if we need to retrieve back the private information. Since the driver doesn't do that, it's not useful to have it. If this is removed, we can also just do a direct return on devm_gpiochip_add_data(). We don't need to print that this call failed as there are other ways to log/see this during probe. Signed-off-by: Alexandru Ardelean --- drivers/gpio/gpio-crystalcove.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/gpio/gpio-crystalcove.c b/drivers/gpio/gpio-crystalcove.c index 2ba225720086..5a909f3c79e8 100644 --- a/drivers/gpio/gpio-crystalcove.c +++ b/drivers/gpio/gpio-crystalcove.c @@ -339,8 +339,6 @@ static int crystalcove_gpio_probe(struct platform_device *pdev) if (!cg) return -ENOMEM; - platform_set_drvdata(pdev, cg); - mutex_init(&cg->buslock); cg->chip.label = KBUILD_MODNAME; cg->chip.direction_input = crystalcove_gpio_dir_in; @@ -372,13 +370,7 @@ static int crystalcove_gpio_probe(struct platform_device *pdev) return retval; } - retval = devm_gpiochip_add_data(&pdev->dev, &cg->chip, cg); - if (retval) { - dev_warn(&pdev->dev, "add gpio chip error: %d\n", retval); - return retval; - } - - return 0; + return devm_gpiochip_add_data(&pdev->dev, &cg->chip, cg); } static struct platform_driver crystalcove_gpio_driver = { -- 2.31.1