From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25895C433ED for ; Fri, 14 May 2021 11:35:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F40B3610EA for ; Fri, 14 May 2021 11:35:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232186AbhENLgc (ORCPT ); Fri, 14 May 2021 07:36:32 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:37224 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230213AbhENLga (ORCPT ); Fri, 14 May 2021 07:36:30 -0400 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtp (Exim 4.89 #2 (Debian)) id 1lhW67-0002vn-LS; Fri, 14 May 2021 19:35:15 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1lhW65-0002Xs-RJ; Fri, 14 May 2021 19:35:13 +0800 Date: Fri, 14 May 2021 19:35:13 +0800 From: Herbert Xu To: Colin King Cc: Matt Mackall , linux-crypto@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] hwrng: amd: remove redundant initialization of variable err Message-ID: <20210514113513.humtmnda7y7s53p6@gondor.apana.org.au> References: <20210429113253.63960-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210429113253.63960-1-colin.king@canonical.com> User-Agent: NeoMutt/20170113 (1.7.2) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 29, 2021 at 12:32:53PM +0100, Colin King wrote: > From: Colin Ian King > > The variable err is being initialized with a value that is > never read and it is being updated later with a new value. The > initialization is redundant and can be removed > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King > --- > drivers/char/hw_random/amd-rng.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt