From: Lee Jones <lee.jones@linaro.org>
To: Moriis Ku <saumah@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Add SUNIX SDC series mfd driver
Date: Fri, 14 May 2021 15:08:55 +0100 [thread overview]
Message-ID: <20210514140855.GG805368@dell> (raw)
In-Reply-To: <20210514112743.4813-1-saumah@gmail.com>
On Fri, 14 May 2021, Moriis Ku wrote:
> From: Morris Ku <saumah@gmail.com>
>
> Signed-off-by: Morris Ku <saumah@gmail.com>
> ---
> sdc_mfd.c | 691 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
> sdc_mfd.h | 58 +++++
> sdc_pci.c | 100 ++++++++
> 3 files changed, 849 insertions(+)
> create mode 100644 sdc_mfd.c
> create mode 100644 sdc_mfd.h
> create mode 100644 sdc_pci.c
Please read and adhere to the upstreaming documentation [0] before
submitting any more patches. There are lots of basic issues with this
patch.
If after reading, you still don't know what I'm referring to, let me
know and I'll do a very quick review just to point you in the right
direction.
Must better if you can use and digest the docs though, it will serve
you well in the future.
[0] Start here: Documentation/process/
> diff --git a/sdc_mfd.c b/sdc_mfd.c
> new file mode 100644
> index 0000000..dc30f3b
> --- /dev/null
> +++ b/sdc_mfd.c
> @@ -0,0 +1,691 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/*
> + * SUNIX SDC mfd driver.
> + *
> + * Copyright (C) 2021, SUNIX Co., Ltd.
> + *
> + * Authors: Jason Lee <jason_lee@sunix.com>
> + */
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2021-05-14 14:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-14 11:27 [PATCH] Add SUNIX SDC series mfd driver Moriis Ku
2021-05-14 14:08 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210514140855.GG805368@dell \
--to=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=saumah@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).