archive mirror
 help / color / mirror / Atom feed
From: Mel Gorman <>
To: Andrew Morton <>
Cc: Chuck Lever <>,
	Jesper Dangaard Brouer <>,
	Thomas Gleixner <>,
	Sebastian Andrzej Siewior <>,
	Peter Zijlstra <>,
	Ingo Molnar <>, Michal Hocko <>,
	Vlastimil Babka <>, Linux-MM <>,
	Linux-RT-Users <>,
	LKML <>
Subject: [PATCH] mm/page_alloc: Split per cpu page lists and zone stats -fix
Date: Fri, 14 May 2021 15:46:22 +0100	[thread overview]
Message-ID: <> (raw)

mm/ is not W=1 clean for allnoconfig but the patch "mm/page_alloc: Split
per cpu page lists and zone stats" makes it worse with the following

  mm/vmstat.c: In function ‘zoneinfo_show_print’:
  mm/vmstat.c:1698:28: warning: variable ‘pzstats’ set but not used [-Wunused-but-set-variable]
     struct per_cpu_zonestat *pzstats;

This is a fix to the mmotm patch

Signed-off-by: Mel Gorman <>
 mm/vmstat.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/mm/vmstat.c b/mm/vmstat.c
index e3bcd317ea55..a2c3f58253be 100644
--- a/mm/vmstat.c
+++ b/mm/vmstat.c
@@ -1695,10 +1695,9 @@ static void zoneinfo_show_print(struct seq_file *m, pg_data_t *pgdat,
 	seq_printf(m, "\n  pagesets");
 	for_each_online_cpu(i) {
 		struct per_cpu_pages *pcp;
-		struct per_cpu_zonestat *pzstats;
+		struct per_cpu_zonestat __maybe_unused *pzstats;
 		pcp = per_cpu_ptr(zone->per_cpu_pageset, i);
-		pzstats = per_cpu_ptr(zone->per_cpu_zonestats, i);
 			   "\n    cpu: %i"
 			   "\n              count: %i"
@@ -1709,6 +1708,7 @@ static void zoneinfo_show_print(struct seq_file *m, pg_data_t *pgdat,
 #ifdef CONFIG_SMP
+		pzstats = per_cpu_ptr(zone->per_cpu_zonestats, i);
 		seq_printf(m, "\n  vm stats threshold: %d",

                 reply	other threads:[~2021-05-14 14:53 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] mm/page_alloc: Split per cpu page lists and zone stats -fix' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
on how to clone and mirror all data and code used for this inbox