From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6920C433ED for ; Sat, 15 May 2021 08:37:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8D9E1613EC for ; Sat, 15 May 2021 08:37:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234492AbhEOIin (ORCPT ); Sat, 15 May 2021 04:38:43 -0400 Received: from jabberwock.ucw.cz ([46.255.230.98]:50186 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234183AbhEOIic (ORCPT ); Sat, 15 May 2021 04:38:32 -0400 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 7E4651C0B81; Sat, 15 May 2021 10:37:18 +0200 (CEST) Date: Sat, 15 May 2021 10:37:17 +0200 From: Pavel Machek To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Paolo Abeni , Willem de Bruijn , "David S. Miller" , Sasha Levin Subject: Re: [PATCH 5.10 380/530] udp: never accept GSO_FRAGLIST packets Message-ID: <20210515083717.GD30461@amd> References: <20210512144819.664462530@linuxfoundation.org> <20210512144832.263718249@linuxfoundation.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="2iBwrppp/7QCDedR" Content-Disposition: inline In-Reply-To: <20210512144832.263718249@linuxfoundation.org> User-Agent: Mutt/1.5.23 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --2iBwrppp/7QCDedR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > From: Paolo Abeni >=20 > [ Upstream commit 78352f73dc5047f3f744764cc45912498c52f3c9 ] >=20 > Currently the UDP protocol delivers GSO_FRAGLIST packets to > the sockets without the expected segmentation. >=20 > This change addresses the issue introducing and maintaining > a couple of new fields to explicitly accept SKB_GSO_UDP_L4 > or GSO_FRAGLIST packets. Additionally updates udp_unexpected_gso() > accordingly. >=20 > UDP sockets enabling UDP_GRO stil keep accept_udp_fraglist > zeroed. What is going on here? accept_udp_fraglist variable is read-only. Should this be dropped? Should=20 commit d18931a92a0b5feddd8a39d097b90ae2867db02f vxlan: allow L4 GRO passthrough =20 be cherry-picked? Best regards, Pavel --=20 DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany --2iBwrppp/7QCDedR Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAmCfiD0ACgkQMOfwapXb+vIJjwCeP1CTpZD86zOct2i7KWCsnPQZ aPoAnizcfWB9nBgjVVeSJsrz85m+8HnB =7GSI -----END PGP SIGNATURE----- --2iBwrppp/7QCDedR--